717498 - nsThread::mEventObservers doesn't get cleared at thread shutdown

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Bobby Holley (:bholley)]

Once the thread manager shuts down, calls to NS_GetCurrentThread return null. So any consumers with registered observers (such as nsXPConnect) have no way to unregister themselves if their shutdown happens after ThreadManager shutdown. This can lead to cycles.

Ideally we'd unify the whole SetObserver vs AddObserver setup, but that's a task for another day.

Comment 1

[Bobby Holley (:bholley)]

Attachment: Bug 717498 - Clear nsThread::mEventObservers at thread shutdown. v1

Attaching a patch. Flagging bsmedberg for review.

Comment 2

[Bobby Holley (:bholley)]

Attachment: Bug 717498 - Clear nsThread::mEventObservers at thread shutdown. v1

Err, that patch had slightly erroneous context due to its location in my patch stack. Here's a version rebased to mozilla-central.

Comment 3

[Bobby Holley (:bholley)]

Pushed to m-i: http://hg.mozilla.org/integration/mozilla-inbound/rev/3f65bc07bd89

Comment 4

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/mozilla-central/rev/3f65bc07bd89