717501 - vm/Unicode.h:index{1,2} could be slimmed down

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nathan Froyd [:froydnj]]

Both js::unicode::index{1,2} are declared as arrays of uint16_t, but no entries in either array are larger than 255.  They should be declared as arrays of uint8_t; doing so saves about 12K of space.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: patch

Patch.  The change to size_t is to make it obvious that we're not depending on the size of the array's element type.  The assert change in make_unicode.py makes the code more obvious, I think.

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: patch

Now with a correct assert!

Comment 3

[Tom S [:evilpie]]

Comment on attachment 587924 [details] [diff] [review]
patch

Review of attachment 587924 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, good find! I guess after 3+ iterations of this patch, I somehow didn't catch this anymore. From my memory there was something at the first try that prevent me from making them uint8.

Comment 4

[Jacek Caban]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6f3285fc0d02

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/6f3285fc0d02