Closed
Bug 717520
Opened 12 years ago
Closed 12 years ago
Correct generation of records for special bookmark folders
Categories
(Firefox for Android Graveyard :: Android Sync, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rnewman, Assigned: rnewman)
References
Details
Records produced from Fennec's local DB store have a different folder structure than the canonical Places-based one. We need to correctly translate IDs, parents, and children to avoid errors on the desktop like this: 1326349988628 Sync.Engine.Bookmarks INFO 0 outgoing items pre-reconciliation 1326349988725 Sync.Store.Bookmarks DEBUG Changing GUID toolbar to 52kDONZHQZ4U 1326349988725 Sync.Engine.Bookmarks DEBUG Reconciling de-duped record: 52kDONZHQZ4U 1326349988726 Sync.Engine.Bookmarks WARN Duplicate record not reconciled on second pass: { id: 52kDONZHQZ4U index: 0 modified: 1326349394.02 ttl: undefined payload: {"id":"52kDONZHQZ4U","children":null,"parentid":"places","title":"Bookmarks Toolbar","type":"folder","description":null,"parentName":""} collection: bookmarks } 1326349988726 Sync.Store.Bookmarks DEBUG created folder 285 under 1 as Bookmarks Toolbar 1326349988727 Sync.Store.Bookmarks DEBUG Reparenting orphans to 285 1326349988729 Sync.Store.Bookmarks DEBUG Processing special node: mobile 1326349988731 Sync.Store.Bookmarks DEBUG Processing special node: places 1326349988731 Sync.Store.Bookmarks DEBUG Changing GUID menu to rFnHP4_mvuZr 1326349988732 Sync.Engine.Bookmarks DEBUG Reconciling de-duped record: rFnHP4_mvuZr 1326349988732 Sync.Engine.Bookmarks WARN Duplicate record not reconciled on second pass: { id: rFnHP4_mvuZr index: 0 modified: 1326349394.02 ttl: undefined payload: {"id":"rFnHP4_mvuZr","children":null,"parentid":"places","title":"Bookmarks Menu","type":"folder","description":null,"parentName":""} collection: bookmarks } 1326349988732 Sync.Store.Bookmarks DEBUG created folder 286 under 1 as Bookmarks Menu 1326349988734 Sync.Store.Bookmarks DEBUG Reparenting orphans to 286 1326349988736 Sync.Store.Bookmarks DEBUG Reparenting orphans to 5 1326349988737 Sync.Collection DEBUG mesg: GET success 200 https://phx-sync545.services.mozilla.com/1.1/c6o7dvmr2c4ud2fyv6woz2u4zi22bcyd/storage/bookmarks?newer=1326349204.87&full=1 1326349988737 Sync.Collection DEBUG GET success 200 https://phx-sync545.services.mozilla.com/1.1/c6o7dvmr2c4ud2fyv6woz2u4zi22bcyd/storage/bookmarks?newer=1326349204.87&full=1 1326349988738 Sync.Engine.Bookmarks INFO Records: 5 applied, 0 failed to apply, 0 newly failed to apply, 0 reconciled. 1326349988738 Sync.Store.Bookmarks DEBUG Could not move item places: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavBookmarksService.moveItem]" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: resource:///modules/services-sync/engines/bookmarks.js :: _orderChildren :: line 902" data: no] 1326349988744 Sync.Status DEBUG Status for engine bookmarks: error.engine.reason.unknown_fail 1326349988744 Sync.Status DEBUG Status.service: success.status_ok => error.sync.failed_partial 1326349988744 Sync.ErrorHandler DEBUG bookmarks failed: guid is null JS Stack trace: idForGUID(null)@bookmarks.js:1146 < _orderChildren()@bookmarks.js:889 < _processIncoming()@bookmarks.js:419 < SyncEngine__sync()@engines.js:1225 < wrappedSync(null)@bookmarks.js:253 < _sync()@bookmarks.js:259 < WrappedNotify()@util.js:148 < Engine_sync()@engines.js:517 < WeaveSvc__syncEngine([object Object])@service.js:1496 < ()@service.js:1389 < WrappedNotify()@util.js:148 < WrappedLock()@util.js:103 < _lockedSync()@service.js:1289 < ()@service.js:1280 < WrappedCatch()@util.js:77 < sync()@service.js:1268 1326349988744 Sync.Engine.Forms INFO 0 outgoing items pre-reconciliation
Assignee | ||
Comment 1•12 years ago
|
||
Fixed with today's bookmark work.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: Mozilla Services → Android Background Services
Updated•7 years ago
|
Product: Android Background Services → Firefox for Android
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•