The default bug view has changed. See this FAQ.

a lot of warning on nsStringAPI.h on win64

RESOLVED FIXED in mozilla12

Status

()

Core
String
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

Trunk
mozilla12
x86
Windows Vista
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 587959 [details] [diff] [review]
fix

https://tbpl.mozilla.org/php/getParsedLog.php?id=8484949&tree=Firefox&full=1

e:\builds\moz2_slave\m-cen-w64\build\xpcom\glue\nsStringAPI.h(1325) : warning C4244: 'argument' : conversion from '__int64' to 'PRUint32', possible loss of data

e:\builds\moz2_slave\m-cen-w64\build\xpcom\glue\nsStringAPI.h(1363) : warning C4244: 'argument' : conversion from '__int64' to 'PRUint32', possible loss of data
Attachment #587959 - Flags: review?(dbaron)
Comment on attachment 587959 [details] [diff] [review]
fix

I suppose I really consider this a bug that we're using PRUint32 where we should be using size_t.  However, r=dbaron, though I'd prefer if you also add
  NS_ABORT_IF_FALSE(PRUint32(end - start) == end - start, "string too long");
Attachment #587959 - Flags: review?(dbaron) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/1a9bebba9dc2
Assignee: nobody → m_kato
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/1a9bebba9dc2

No need for the [inbound], thanks
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.