Last Comment Bug 717526 - a lot of warning on nsStringAPI.h on win64
: a lot of warning on nsStringAPI.h on win64
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: String (show other bugs)
: Trunk
: x86 Windows Vista
: -- normal (vote)
: mozilla12
Assigned To: Makoto Kato [:m_kato]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-11 23:34 PST by Makoto Kato [:m_kato]
Modified: 2012-01-25 07:04 PST (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (1.20 KB, patch)
2012-01-11 23:34 PST, Makoto Kato [:m_kato]
dbaron: review+
Details | Diff | Splinter Review

Description Makoto Kato [:m_kato] 2012-01-11 23:34:20 PST
Created attachment 587959 [details] [diff] [review]
fix

https://tbpl.mozilla.org/php/getParsedLog.php?id=8484949&tree=Firefox&full=1

e:\builds\moz2_slave\m-cen-w64\build\xpcom\glue\nsStringAPI.h(1325) : warning C4244: 'argument' : conversion from '__int64' to 'PRUint32', possible loss of data

e:\builds\moz2_slave\m-cen-w64\build\xpcom\glue\nsStringAPI.h(1363) : warning C4244: 'argument' : conversion from '__int64' to 'PRUint32', possible loss of data
Comment 1 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2012-01-24 15:18:33 PST
Comment on attachment 587959 [details] [diff] [review]
fix

I suppose I really consider this a bug that we're using PRUint32 where we should be using size_t.  However, r=dbaron, though I'd prefer if you also add
  NS_ABORT_IF_FALSE(PRUint32(end - start) == end - start, "string too long");
Comment 3 :Ms2ger (⌚ UTC+1/+2) 2012-01-25 07:04:42 PST
https://hg.mozilla.org/mozilla-central/rev/1a9bebba9dc2

No need for the [inbound], thanks

Note You need to log in before you can comment on or make changes to this bug.