Need to support new MathML3 href attribute

RESOLVED FIXED

Status

SeaMonkey
UI Design
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
As of bug 427990 MathML nodes can now use an href attribute instead of an XLink to create a link inside a mathematical formula.

Some test cases are available on bug 534968.
(Assignee)

Comment 1

7 years ago
Created attachment 588019 [details] [diff] [review]
Possible patch

Fixes, so far:
Ctrl+Click on MathML Link to open in new tab
Correct menuitems on right-click of MathML link
Properties menuitem works on MathML link
Page Info detects MathML links
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #588019 - Flags: review?(iann_bugzilla)

Comment 2

6 years ago
Comment on attachment 588019 [details] [diff] [review]
Possible patch

This looks good so far but was just wondering if there was any code duplication that could be removed around the metadata.js and pageInfo.js changes.
Attachment #588019 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 588429 [details] [diff] [review]
Addressed review comments
Attachment #588019 - Attachment is obsolete: true
Attachment #588429 - Flags: review?(iann_bugzilla)

Updated

6 years ago
Attachment #588429 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 4

6 years ago
Pushed changeset 7a34e038ee94 to comm-central.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
I'm 99% sure this caused bug 720225. :-(
Blocks: 720225
Now that bug 720225 is fixed, I get:

Error: linkNode.hasAttributeNS is not a function
Source File: chrome://communicator/content/contentAreaClick.js
Line: 76

when clicking an empty space of a website in a browser window. [I guess this can be reproduced in many other ways.] When the error occurs for me, linkNode.nodeName = "#document".
(Assignee)

Comment 7

6 years ago
Ah yes, I lost the element check that the previous code had. File a bug?
You need to log in before you can comment on or make changes to this bug.