717611 - Web Console clear button does not clear cached errors

Status: RESOLVED FIXED

(DevTools :: Console, defect, P2)

Description

[Mihai Sucan [:msucan]]

Follow up from bug 611032 comment 61:

"- nsIConsoleService does not have a way to remove individual messages, or to clear all messages associated to a specific inner window ID. This means that the Web Console clear button only temporarily clears nsIScriptErrors. They show again after reopen.

This should be fixed inside the nsIConsoleService. The 250 messages limit is also hard coded..."

An alternate "solution" is to allow the Clear button to clear all of the messages, at once, from the nsIConsoleService. Meaning that any cached errors in the other tabs are lost. This is only a workaround - what we really need is a way to remove messages associated to the inner window ID we want.

We might want to base this bug fix on top of bug 692824.

Comment 1

[Patrick Brosset <:pbro>]

Not touches in the past 6 years. No user complaints. Closing.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

(it's fixed BTW)
it's not, I might investigate a bit

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 717611 - Add nsConsoleService::ResetWindow to clear messages for a given window id; r=baku.

This will allow devtools to clear cached error messages, like
we already can with ConsoleAPI messages.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 717611 - Clear ConsoleService cached messages in webconsole actor's clearMessagesCache; r=Honza.

We were clearing the ConsoleAPI messages, but not the one
issued by the ConsoleService. A previous patch added
Services.console.resetWindow, so we can use it in clearMessagesCache.

Depends on D21693

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

TRY push

I'm really not confident of my C++ skills, but it fixes the console issue.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6da9d84ec243
Add nsConsoleService::ResetWindow to clear messages for a given window id; r=baku.
https://hg.mozilla.org/integration/autoland/rev/60f067345542
Clear ConsoleService cached messages in webconsole actor's clearMessagesCache; r=Honza.

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/6da9d84ec243
https://hg.mozilla.org/mozilla-central/rev/60f067345542