717619 - Form autocomplete popup position is incorrect in combination with zoom level and scroll position

Status: VERIFIED WORKSFORME

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Martijn Wargers (dead)]

Steps to reproduce:
1- Go to http://people.mozilla.org/~mwargers/tests/autocomplete_forms/textinput_form.html
2- Make sure you already have one autocomplete entry available.
3- Scroll down to the bottom, tap the input there, vkb appears, type something that makes the form autocomplete popup appear.
4- Tap on one of the autocomplete entries in the popup
5- Vkb disappears, page scrolls to the top (bug, I guess??). Scroll down again to the bottom input
6- Tap on the input (vkb appears again), type something that makes the autocomplete popup apear again.

Expected result:
- Form autcomplete popup should appear, but input should be visible too

Actual result:
- Form autocomplete popup appears, but input is not visibile. It seems to be overlayed by the form autocomplete popup.

Comment 1

[Martijn Wargers (dead)]

Other, simpler way to reproduce:
- Go to http://people.mozilla.org/~mwargers/tests/autocomplete_forms/textinput_form.html
- Tap on the top input, vkb comes up
- Scroll down to bottom input
- Tap on bottom input, type something so form autocomplete popup comes up

Comment 2

[Martijn Wargers (dead)]

Ok, this seems to be related to the zoom level of the page.
When the page is zoomed in, you don't see the form autocomplete popup appear at all for the bottom input.

Comment 3

[:Margaret Leibovic]

I'm not sure about the scrolling problems, but the fact that the autocomplete popup appears on top of the input is probably due to the fact that there's no space below the input box. I don't remember ever discussing a design to deal with this issue. Did XUL fennec do anything to position the popup differently if there wasn't enough room below the input? Perhaps position it above?

Comment 4

[Martijn Wargers (dead)]

Attachment: testcase

I've updated the testcase a bit. The bug only seems to happen with form autocomplete at the bottom and higher zoom level.

Comment 5

[Martijn Wargers (dead)]

Attachment: Screenshot of correct behavior

Comment 6

[Martijn Wargers (dead)]

Attachment: Screenshot of bug

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Margaret Leibovic [:margaret] from comment #3)
> I'm not sure about the scrolling problems, but the fact that the
> autocomplete popup appears on top of the input is probably due to the fact
> that there's no space below the input box. I don't remember ever discussing
> a design to deal with this issue. Did XUL fennec do anything to position the
> popup differently if there wasn't enough room below the input? Perhaps
> position it above?

I'm not 100% sure XUL Fennec handle this any better, but positioning the popup above the input seems like a good choice. I wonder if we just aren't handling the zoom when trying to calculate the position? Unzoomed works fine.

Comment 8

[:Margaret Leibovic]

Hm, it looks like we should be handling zoom: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/AutoCompletePopup.java#119

Sriram wrote this, but I can look into it more if I find some time later.

Comment 9

[Sriram Ramasubramanian [:sriram]]

Quick look tells me that zoom is not accounted when the page is zoomed after popup is shown.
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/AutoCompletePopup.java#101

Comment 10

[Aaron Train [:aaronmt]]

Sill an issue.

Comment 11

[Wesley Johnston (:wesj)]

we've made some improvements to the form popup lately. this wfm now.

Comment 12

[Martijn Wargers (dead)]

Yeah, verified worksforme.