717683 - get rid of nsIAccessibleDocument uses

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: part 1/4

Comment 2

[Trevor Saunders (:tbsaunde)]

Attachment: part 2 / 4

Comment 3

[Trevor Saunders (:tbsaunde)]

Attachment: part 3 / 4

Comment 4

[Trevor Saunders (:tbsaunde)]

Attachment: part 4/4

Comment 5

[Trevor Saunders (:tbsaunde)]

Attachment: patch 1/4 v2

Comment 6

[Hubert Figuiere [:hub]]

Comment on attachment 588138 [details] [diff] [review]
patch 1/4 v2

Review of attachment 588138 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/atk/nsMaiInterfaceDocument.cpp
@@ +105,3 @@
>  
> +  // according to atkobject.h, AtkAttributeSet is a GSList
> +  GSList *attributes = nsnull;

GSList* attributes = nsnull;

Comment 7

[Hubert Figuiere [:hub]]

Comment on attachment 588101 [details] [diff] [review]
part 2 / 4

Review of attachment 588101 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/atk/nsAccessibleWrap.cpp
@@ +440,5 @@
>      if (accessInterfaceValue) {
>         interfacesBits |= 1 << MAI_INTERFACE_VALUE; 
>      }
>  
> +    // document accessibl

typo: accessible

Comment 8

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 588138 [details] [diff] [review]
patch 1/4 v2

Review of attachment 588138 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. Looks good. Nice to see you removed those duplicated NS_ENSURE* calls too. I'm unsure if Ginn cares about the spacing (2 vs 4) but that shouldn't prevent landing.

::: accessible/src/atk/nsMaiInterfaceDocument.cpp
@@ +105,3 @@
>  
> +  // according to atkobject.h, AtkAttributeSet is a GSList
> +  GSList *attributes = nsnull;

Yep, good eye.

::: accessible/src/atk/nsMaiInterfaceDocument.h
@@ +44,5 @@
>  
>  G_BEGIN_DECLS
>  
>  /* document interface callbacks */
>  void documentInterfaceInitCB(AtkDocumentIface *aIface);

nit: you could change the param to AtkDocumentIface* aIface while here.

Comment 9

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 588109 [details] [diff] [review]
part 4/4

Review of attachment 588109 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. Shazam!

Comment 10

[Trevor Saunders (:tbsaunde)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5f6a7d59e259
https://hg.mozilla.org/integration/mozilla-inbound/rev/a57d0b0d3c28
https://hg.mozilla.org/integration/mozilla-inbound/rev/1660517d25b1
https://hg.mozilla.org/integration/mozilla-inbound/rev/79ffbbba5d53

Comment 11

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/5f6a7d59e259
https://hg.mozilla.org/mozilla-central/rev/a57d0b0d3c28
https://hg.mozilla.org/mozilla-central/rev/1660517d25b1
https://hg.mozilla.org/mozilla-central/rev/79ffbbba5d53