Last Comment Bug 717683 - get rid of nsIAccessibleDocument uses
: get rid of nsIAccessibleDocument uses
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla12
Assigned To: Trevor Saunders (:tbsaunde)
:
Mentors:
Depends on:
Blocks: cleana11y dexpcoma11y
  Show dependency treegraph
 
Reported: 2012-01-12 10:50 PST by Trevor Saunders (:tbsaunde)
Modified: 2012-01-17 07:44 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
part 1/4 (7.50 KB, patch)
2012-01-12 11:00 PST, Trevor Saunders (:tbsaunde)
no flags Details | Diff | Splinter Review
part 2 / 4 (1.27 KB, patch)
2012-01-12 11:01 PST, Trevor Saunders (:tbsaunde)
dbolter: review+
Details | Diff | Splinter Review
part 3 / 4 (1.16 KB, patch)
2012-01-12 11:02 PST, Trevor Saunders (:tbsaunde)
dbolter: review+
Details | Diff | Splinter Review
part 4/4 (3.36 KB, patch)
2012-01-12 11:04 PST, Trevor Saunders (:tbsaunde)
dbolter: review+
Details | Diff | Splinter Review
patch 1/4 v2 (7.55 KB, patch)
2012-01-12 11:56 PST, Trevor Saunders (:tbsaunde)
dbolter: review+
Details | Diff | Splinter Review

Description Trevor Saunders (:tbsaunde) 2012-01-12 10:50:51 PST

    
Comment 1 Trevor Saunders (:tbsaunde) 2012-01-12 11:00:50 PST
Created attachment 588099 [details] [diff] [review]
part 1/4
Comment 2 Trevor Saunders (:tbsaunde) 2012-01-12 11:01:47 PST
Created attachment 588101 [details] [diff] [review]
part 2 / 4
Comment 3 Trevor Saunders (:tbsaunde) 2012-01-12 11:02:53 PST
Created attachment 588104 [details] [diff] [review]
part 3 / 4
Comment 4 Trevor Saunders (:tbsaunde) 2012-01-12 11:04:21 PST
Created attachment 588109 [details] [diff] [review]
part 4/4
Comment 5 Trevor Saunders (:tbsaunde) 2012-01-12 11:56:19 PST
Created attachment 588138 [details] [diff] [review]
patch 1/4 v2
Comment 6 Hubert Figuiere [:hub] 2012-01-12 13:15:46 PST
Comment on attachment 588138 [details] [diff] [review]
patch 1/4 v2

Review of attachment 588138 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/atk/nsMaiInterfaceDocument.cpp
@@ +105,3 @@
>  
> +  // according to atkobject.h, AtkAttributeSet is a GSList
> +  GSList *attributes = nsnull;

GSList* attributes = nsnull;
Comment 7 Hubert Figuiere [:hub] 2012-01-12 13:16:32 PST
Comment on attachment 588101 [details] [diff] [review]
part 2 / 4

Review of attachment 588101 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/atk/nsAccessibleWrap.cpp
@@ +440,5 @@
>      if (accessInterfaceValue) {
>         interfacesBits |= 1 << MAI_INTERFACE_VALUE; 
>      }
>  
> +    // document accessibl

typo: accessible
Comment 8 David Bolter [:davidb] ***PTO until 29th*** 2012-01-13 12:47:57 PST
Comment on attachment 588138 [details] [diff] [review]
patch 1/4 v2

Review of attachment 588138 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. Looks good. Nice to see you removed those duplicated NS_ENSURE* calls too. I'm unsure if Ginn cares about the spacing (2 vs 4) but that shouldn't prevent landing.

::: accessible/src/atk/nsMaiInterfaceDocument.cpp
@@ +105,3 @@
>  
> +  // according to atkobject.h, AtkAttributeSet is a GSList
> +  GSList *attributes = nsnull;

Yep, good eye.

::: accessible/src/atk/nsMaiInterfaceDocument.h
@@ +44,5 @@
>  
>  G_BEGIN_DECLS
>  
>  /* document interface callbacks */
>  void documentInterfaceInitCB(AtkDocumentIface *aIface);

nit: you could change the param to AtkDocumentIface* aIface while here.
Comment 9 David Bolter [:davidb] ***PTO until 29th*** 2012-01-13 12:52:06 PST
Comment on attachment 588109 [details] [diff] [review]
part 4/4

Review of attachment 588109 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. Shazam!

Note You need to log in before you can comment on or make changes to this bug.