get rid of nsIAccessibleDocument uses

RESOLVED FIXED in mozilla12

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Tracking

(Blocks: 1 bug)

unspecified
mozilla12
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 588099 [details] [diff] [review]
part 1/4
Attachment #588099 - Flags: review?(bolterbugz)
(Assignee)

Comment 2

5 years ago
Created attachment 588101 [details] [diff] [review]
part 2 / 4
Attachment #588101 - Flags: review?(bolterbugz)
(Assignee)

Comment 3

5 years ago
Created attachment 588104 [details] [diff] [review]
part 3 / 4
Attachment #588104 - Flags: review?(bolterbugz)
(Assignee)

Comment 4

5 years ago
Created attachment 588109 [details] [diff] [review]
part 4/4
Attachment #588109 - Flags: review?(bolterbugz)
(Assignee)

Comment 5

5 years ago
Created attachment 588138 [details] [diff] [review]
patch 1/4 v2
Attachment #588099 - Attachment is obsolete: true
Attachment #588099 - Flags: review?(bolterbugz)
Attachment #588138 - Flags: review?(bolterbugz)
Comment on attachment 588138 [details] [diff] [review]
patch 1/4 v2

Review of attachment 588138 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/atk/nsMaiInterfaceDocument.cpp
@@ +105,3 @@
>  
> +  // according to atkobject.h, AtkAttributeSet is a GSList
> +  GSList *attributes = nsnull;

GSList* attributes = nsnull;
Comment on attachment 588101 [details] [diff] [review]
part 2 / 4

Review of attachment 588101 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/atk/nsAccessibleWrap.cpp
@@ +440,5 @@
>      if (accessInterfaceValue) {
>         interfacesBits |= 1 << MAI_INTERFACE_VALUE; 
>      }
>  
> +    // document accessibl

typo: accessible
Comment on attachment 588138 [details] [diff] [review]
patch 1/4 v2

Review of attachment 588138 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. Looks good. Nice to see you removed those duplicated NS_ENSURE* calls too. I'm unsure if Ginn cares about the spacing (2 vs 4) but that shouldn't prevent landing.

::: accessible/src/atk/nsMaiInterfaceDocument.cpp
@@ +105,3 @@
>  
> +  // according to atkobject.h, AtkAttributeSet is a GSList
> +  GSList *attributes = nsnull;

Yep, good eye.

::: accessible/src/atk/nsMaiInterfaceDocument.h
@@ +44,5 @@
>  
>  G_BEGIN_DECLS
>  
>  /* document interface callbacks */
>  void documentInterfaceInitCB(AtkDocumentIface *aIface);

nit: you could change the param to AtkDocumentIface* aIface while here.
Attachment #588138 - Flags: review?(bolterbugz) → review+

Updated

5 years ago
Attachment #588101 - Flags: review?(bolterbugz) → review+

Updated

5 years ago
Attachment #588104 - Flags: review?(bolterbugz) → review+
Comment on attachment 588109 [details] [diff] [review]
part 4/4

Review of attachment 588109 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. Shazam!
Attachment #588109 - Flags: review?(bolterbugz) → review+
(Assignee)

Comment 10

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f6a7d59e259
https://hg.mozilla.org/integration/mozilla-inbound/rev/a57d0b0d3c28
https://hg.mozilla.org/integration/mozilla-inbound/rev/1660517d25b1
https://hg.mozilla.org/integration/mozilla-inbound/rev/79ffbbba5d53
https://hg.mozilla.org/mozilla-central/rev/5f6a7d59e259
https://hg.mozilla.org/mozilla-central/rev/a57d0b0d3c28
https://hg.mozilla.org/mozilla-central/rev/1660517d25b1
https://hg.mozilla.org/mozilla-central/rev/79ffbbba5d53
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.