Closed
Bug 717683
Opened 14 years ago
Closed 14 years ago
get rid of nsIAccessibleDocument uses
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: tbsaunde, Assigned: tbsaunde)
References
(Blocks 1 open bug)
Details
Attachments
(4 files, 1 obsolete file)
|
1.27 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
|
1.16 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
|
3.36 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
|
7.55 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #588099 -
Flags: review?(bolterbugz)
|
|
Assignee | |
Comment 2•14 years ago
|
||
Attachment #588101 -
Flags: review?(bolterbugz)
|
|
Assignee | |
Comment 3•14 years ago
|
||
Attachment #588104 -
Flags: review?(bolterbugz)
|
|
Assignee | |
Comment 4•14 years ago
|
||
Attachment #588109 -
Flags: review?(bolterbugz)
|
|
Assignee | |
Comment 5•14 years ago
|
||
Attachment #588099 -
Attachment is obsolete: true
Attachment #588099 -
Flags: review?(bolterbugz)
Attachment #588138 -
Flags: review?(bolterbugz)
|
||
Comment 6•14 years ago
|
||
Comment on attachment 588138 [details] [diff] [review]
patch 1/4 v2
Review of attachment 588138 [details] [diff] [review]:
-----------------------------------------------------------------
::: accessible/src/atk/nsMaiInterfaceDocument.cpp
@@ +105,3 @@
>
> + // according to atkobject.h, AtkAttributeSet is a GSList
> + GSList *attributes = nsnull;
GSList* attributes = nsnull;
|
|
||
Comment 7•14 years ago
|
||
Comment on attachment 588101 [details] [diff] [review]
part 2 / 4
Review of attachment 588101 [details] [diff] [review]:
-----------------------------------------------------------------
::: accessible/src/atk/nsAccessibleWrap.cpp
@@ +440,5 @@
> if (accessInterfaceValue) {
> interfacesBits |= 1 << MAI_INTERFACE_VALUE;
> }
>
> + // document accessibl
typo: accessible
|
||
Comment 8•14 years ago
|
||
Comment on attachment 588138 [details] [diff] [review]
patch 1/4 v2
Review of attachment 588138 [details] [diff] [review]:
-----------------------------------------------------------------
r=me. Looks good. Nice to see you removed those duplicated NS_ENSURE* calls too. I'm unsure if Ginn cares about the spacing (2 vs 4) but that shouldn't prevent landing.
::: accessible/src/atk/nsMaiInterfaceDocument.cpp
@@ +105,3 @@
>
> + // according to atkobject.h, AtkAttributeSet is a GSList
> + GSList *attributes = nsnull;
Yep, good eye.
::: accessible/src/atk/nsMaiInterfaceDocument.h
@@ +44,5 @@
>
> G_BEGIN_DECLS
>
> /* document interface callbacks */
> void documentInterfaceInitCB(AtkDocumentIface *aIface);
nit: you could change the param to AtkDocumentIface* aIface while here.
Attachment #588138 -
Flags: review?(bolterbugz) → review+
|
|
||
Updated•14 years ago
|
Attachment #588101 -
Flags: review?(bolterbugz) → review+
|
|
||
Updated•14 years ago
|
Attachment #588104 -
Flags: review?(bolterbugz) → review+
|
|
||
Comment 9•14 years ago
|
||
Comment on attachment 588109 [details] [diff] [review]
part 4/4
Review of attachment 588109 [details] [diff] [review]:
-----------------------------------------------------------------
r=me. Shazam!
Attachment #588109 -
Flags: review?(bolterbugz) → review+
|
|
Assignee | |
Comment 10•14 years ago
|
||
|
||
Comment 11•14 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5f6a7d59e259
https://hg.mozilla.org/mozilla-central/rev/a57d0b0d3c28
https://hg.mozilla.org/mozilla-central/rev/1660517d25b1
https://hg.mozilla.org/mozilla-central/rev/79ffbbba5d53
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in
before you can comment on or make changes to this bug.
Description
•