71771 - Tabbed dialogs always process "Enter/Return" key even if not "default" key.

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Charles Manske]

When you use the "Enter/Return" key, it *always* fires the "onok" handler, even if
I've removed the "default" attribute from the "Ok" button and set it on a button
within a particular panel. Also, trying to trap that key with this kind of code
doesn't work either:
<textfield flex="1" oninput="doCSSEnabling()" onkeyup="if (event.keyCode == 13)
onAddCSSAttribute();"/>

Comment 1

[Boris Zbarsky [:bzbarsky]]

See also bug 71196.  The problem is in the default dialog keyset...

Comment 2

[Charles Manske]

Probably a dup of 71196, although that problem is not described as tabbed dialog
related. Composer's spelling dialog successfully shifts "default" key from one
button to another, but this dialog is not using the usual overlay for "onok"
handling, so it's irrelevant to this problem.

Comment 3

[Paul Chen]

Marking nsbeta1-, future, too many things on Ben's plate for beta1

Comment 4

[Charles Manske]

Can we get some attention on this? It really inhibits good dialog behavior.
Often, you want to use "Enter" to add values to a list, but we can't do that
when the "Enter" key is hard-wired to the OK in a tabbed dialog.

Comment 5

[Boris Zbarsky [:bzbarsky]]

over to hewitt per hyatt's comments in bug 84602.  Apparently the <dialog>
binding should handle this correctly...

Comment 6

[Joe Hewitt (gone)]

This is now fixed if you use the <dialog/> tag.