Last Comment Bug 717870 - Space is incorrectly ignored when adding text to <svg:text>
: Space is incorrectly ignored when adding text to <svg:text>
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: SVG (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla12
Assigned To: Robert Longson
:
Mentors:
Depends on:
Blocks: refdyn
  Show dependency treegraph
 
Reported: 2012-01-12 23:45 PST by Jesse Ruderman
Modified: 2012-02-12 13:58 PST (History)
3 users (show)
longsonr: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
testcase (clicking should have no effect) (603 bytes, image/svg+xml)
2012-01-12 23:45 PST, Jesse Ruderman
no flags Details
patch (5.67 KB, patch)
2012-01-13 12:07 PST, Robert Longson
dholbert: review+
Details | Diff | Review

Description Jesse Ruderman 2012-01-12 23:45:02 PST
Created attachment 588332 [details]
testcase (clicking should have no effect)
Comment 1 Daniel Holbert [:dholbert] 2012-01-13 00:20:42 PST
Confirmed. Same behavior at least as far back as Firefox 3.5.16, so not a regression, at least not a recent one.
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.16) Gecko/20101130 Firefox/3.5.16
Comment 2 Robert Longson 2012-01-13 12:07:30 PST
Created attachment 588486 [details] [diff] [review]
patch
Comment 3 Daniel Holbert [:dholbert] 2012-01-13 12:21:46 PST
Comment on attachment 588486 [details] [diff] [review]
patch

Looks great!

One suggestion -- a brief comment would be helpful above or inside SetWhitespaceHandling(), just to be clear up-front what it's trying to do.

Something like
> // Trim whitespace up to the first non-whitespace frame
> // and after the last non-whitespace frame.

r=me with that
Comment 5 Jonathan Kew (:jfkthame) 2012-01-16 04:59:00 PST
https://hg.mozilla.org/mozilla-central/rev/256c57537507

Note You need to log in before you can comment on or make changes to this bug.