717924 - Move the HTML tree view in the Page Inspector above the inspector toolbar

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Rob Campbell [:rc] (:robcee)]

Currently, the HTML tree view is below the page inspector toolbar. We want to move this above the (inspector) toolbar to better isolate this view from the page-centric tools.

We may want to file a separate bug to split it out of the registerTools mechanism used by the Inspector as these tools should be specifically for (nodecentric) tools that show up in the node sidebar.

Comment 1

[Paul Rouget [:paul]]

Attachment: patch v1

Comment 2

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 590403 [details] [diff] [review]
patch v1

   openDocked: function TP_openDocked()
   {
     let treeBox = null;
-    let toolbar = this.IUI.toolbar.nextSibling; // Addons bar, typically
-    let toolbarParent =
-      this.IUI.browser.ownerDocument.getElementById("browser-bottombox");
     treeBox = this.document.createElement("vbox");
     treeBox.id = "inspector-tree-box";
     treeBox.state = "open"; // for the registerTools API.

we should probably lose this comment since we're not going to be going through registerTools anymore.

Comment 3

[Rob Campbell [:rc] (:robcee)]

neat.

I don't think that's the styling we want on the splitter though.

Either what we have on the Web Console or a hidden splitter like we have on the Style sidebar.

Comment 4

[Paul Rouget [:paul]]

Attachment: Patch v1.1

Comment 5

[Paul Rouget [:paul]]

Attachment: Patch v1.2

Comment 6

[Paul Rouget [:paul]]

Attachment: Patch v1.3

Comment 7

[Paul Rouget [:paul]]

Attachment: Patch v1.4

Comment 8

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 592481 [details] [diff] [review]
Patch v1.4

+      <toolbarbutton id="inspector-inspect-toolbutton"
+                      class="devtools-toolbarbutton"
+                      label="&inspectButton.label;"
+                      accesskey="&inspectButton.accesskey;"
+                      command="Inspector:Inspect"/>
+      <arrowscrollbox id="inspector-breadcrumbs"
+                      flex="1" orient="horizontal"
+                      clicktoscroll="true"/>

nit: indenting's a bit weird here. Should be lined up under the "i" in id.

in gnomestripe:
+/* Highlighter toolbar - HTML Tree */
+
+#inspector-tree-splitter {
+  -moz-appearance: none;
+  height: 4px;
+  border-top: 1px solid hsla(210,8%,5%,.45);
+  background: -moz-linear-gradient(top, hsl(210,11%,36%), hsl(210,11%,18%));
+}

no border-bottom?

from gnomestripe/inspector.css:

 
 body {
   margin: 0;
   overflow: auto;
   font-family: Lucida Grande, sans-serif;
   font-size: 11px;
-  border-top: 1px solid #BBB9BA;
+  padding-top: 5px;

why this change? Does the padding here accomodate all of the splitter?

Seems ok, r+ with the indentation fixed.

Comment 9

[Paul Rouget [:paul]]

(In reply to Rob Campbell [:rc] (robcee) from comment #8)
> in gnomestripe:
> +/* Highlighter toolbar - HTML Tree */
> +
> +#inspector-tree-splitter {
> +  -moz-appearance: none;
> +  height: 4px;
> +  border-top: 1px solid hsla(210,8%,5%,.45);
> +  background: -moz-linear-gradient(top, hsl(210,11%,36%), hsl(210,11%,18%));
> +}
> 
> no border-bottom?

No. Do you think we need one?

> from gnomestripe/inspector.css:
> 
>  
>  body {
>    margin: 0;
>    overflow: auto;
>    font-family: Lucida Grande, sans-serif;
>    font-size: 11px;
> -  border-top: 1px solid #BBB9BA;
> +  padding-top: 5px;
> 
> why this change? Does the padding here accomodate all of the splitter?

Without that, immediately after the splitter we see the doctype, stuck to the splitter. It's weird.

Comment 10

[Paul Rouget [:paul]]

Attachment: Patch v1.5

Comment 11

[Rob Campbell [:rc] (:robcee)]

(In reply to Paul Rouget [:paul] from comment #9)
> (In reply to Rob Campbell [:rc] (robcee) from comment #8)
> > in gnomestripe:
> > +/* Highlighter toolbar - HTML Tree */
> > +
> > +#inspector-tree-splitter {
> > +  -moz-appearance: none;
> > +  height: 4px;
> > +  border-top: 1px solid hsla(210,8%,5%,.45);
> > +  background: -moz-linear-gradient(top, hsl(210,11%,36%), hsl(210,11%,18%));
> > +}
> > 
> > no border-bottom?
> 
> No. Do you think we need one?

Possibly. I'd defer to shorlander and co. for that one.

> > -  border-top: 1px solid #BBB9BA;
> > +  padding-top: 5px;
> > 
> > why this change? Does the padding here accomodate all of the splitter?
> 
> Without that, immediately after the splitter we see the doctype, stuck to
> the splitter. It's weird.

Ah, makes sense.

Comment 12

[Rob Campbell [:rc] (:robcee)]

is this ready to go? I'd like to land it.

Comment 13

[Paul Rouget [:paul]]

Attachment: Patch v1.6

Comment 14

[Paul Rouget [:paul]]

(In reply to Rob Campbell [:rc] (robcee) from comment #12)
> is this ready to go? I'd like to land it.

We need a review from Dão first.

Comment 15

[Rob Campbell [:rc] (:robcee)]

ping for review! This is holding up other patches.

Comment 16

[Dão Gottwald [:dao]]

Comment on attachment 592771 [details] [diff] [review]
Patch v1.5

>+      <toolbarbutton id="highlighter-closebutton"
>+                      oncommand="InspectorUI.closeInspectorUI(false);"
>+                      tooltiptext="&inspectCloseButton.tooltiptext;"/>

>+        <toolbarbutton id="inspector-3D-button"
>+                        class="devtools-toolbarbutton"
>+                        hidden="true"
>+                        label="&inspect3DViewButton.label;"
>+                        accesskey="&inspect3DViewButton.accesskey;"
>+                        command="Inspector:Tilt"/>
>+        <toolbarbutton id="inspector-style-button"
>+                        class="devtools-toolbarbutton"
>+                        label="&inspectStyleButton.label;"
>+                        accesskey="&inspectStyleButton.accesskey;"
>+                        command="Inspector:Sidebar"/>

>+      <toolbarbutton id="highlighter-closebutton"
>+                      oncommand="InspectorUI.closeInspectorUI(false);"
>+                      tooltiptext="&inspectCloseButton.tooltiptext;"/>

indentation is off

>       this.IUI.toolbar.removeAttribute("treepanel-open");

still need to remove this

>+#inspector-tree-splitter {
>+  -moz-appearance: none;
>+  height: 4px;
>+  border-top: 1px solid hsla(210,8%,5%,.45);
>+  background: -moz-linear-gradient(top, hsl(210,11%,36%), hsl(210,11%,18%));
>+}

This should have a height of 1px similarly to devtools-side-splitter being 1px wide.

I also noticed that the toolbar has a bogus bottom border, although not caused by this patch.

Why is there a newer patch attached while the review request flag remains on this one?

Comment 17

[Rob Campbell [:rc] (:robcee)]

Attachment: Patch v1.6 - rebased

Comment 18

[Paul Rouget [:paul]]

Attachment: patch v1.7

indentation fixed, removed removeAttribute()

Comment 19

[Paul Rouget [:paul]]

(In reply to Dão Gottwald [:dao] from comment #16)
> >+#inspector-tree-splitter {
> >+  -moz-appearance: none;
> >+  height: 4px;
> >+  border-top: 1px solid hsla(210,8%,5%,.45);
> >+  background: -moz-linear-gradient(top, hsl(210,11%,36%), hsl(210,11%,18%));
> >+}
> 
> This should have a height of 1px similarly to devtools-side-splitter being 1px wide.

It's what I did at first, but that looks too weird.
We need a clear separation between the content and the panel here.

> I also noticed that the toolbar has a bogus bottom border, although not caused by this patch.

Can you be more specific?

> Why is there a newer patch attached while the review request flag remains on this one?

Sorry about that. The only difference is the addition of a border-bottom to the #inspector-tree-splitter

Comment 20

[Dão Gottwald [:dao]]

Attachment: bottom border

(In reply to Paul Rouget [:paul] from comment #19)
> > I also noticed that the toolbar has a bogus bottom border, although not caused by this patch.
> 
> Can you be more specific?

Comment 21

[Dão Gottwald [:dao]]

(In reply to Paul Rouget [:paul] from comment #19)
> > This should have a height of 1px similarly to devtools-side-splitter being 1px wide.
> 
> It's what I did at first, but that looks too weird.
> We need a clear separation between the content and the panel here.

Why exactly would this be an issue here but not for devtools-side-splitter?

Comment 22

[Paul Rouget [:paul]]

(In reply to Dão Gottwald [:dao] from comment #21)
> (In reply to Paul Rouget [:paul] from comment #19)
> > > This should have a height of 1px similarly to devtools-side-splitter being 1px wide.
> > 
> > It's what I did at first, but that looks too weird.
> > We need a clear separation between the content and the panel here.
> 
> Why exactly would this be an issue here but not for devtools-side-splitter?

The devtools-side-splitter doesn't cut any content. The inspector-tree-splitter does.
Screenshot:
  1px splitter http://i.imgur.com/IHlSe.png
  4px splitter http://i.imgur.com/n1PhO.png

Comment 23

[Paul Rouget [:paul]]

I am not strongly against having a 1px splitter though.

Comment 24

[Paul Rouget [:paul]]

Stephen, can you please tell us what we should do here?

Comment 25

[Paul Rouget [:paul]]

Stephen said 1px.

Comment 26

[Paul Rouget [:paul]]

Attachment: patch v1.8

1px splitter

Comment 27

[Paul Rouget [:paul]]

Attachment: patch v1.9

Comment 28

[Paul Rouget [:paul]]

Thank you Dão.

Comment 29

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/3996ac18197d

Comment 30

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/3996ac18197d