717933 - Adding Yandex to Turkish Firefox search engines

Status: RESOLVED FIXED

(Mozilla Localizations :: tr / Turkish, defect)

Description

[Selim Şumlu]

Hi,

We are currently considering adding Yandex (www.yandex.com.tr) to Turkish Firefox's search engines.

As far as I know, Mozilla has a search partnership deal with Yandex but does it only cover Russian Firefox or Yandex Russia?

Even if there's no partnership for Turkey, please let us know if we need to add any parameters to the XML file.

I may also get in touch with Yandex Turkey if needed.

Comment 1

[Axel Hecht [:Pike]]

CCing a few folks.

For starters, we should figure out what makes yandex a good choice for Turkey. Selim, mind filling us in there?

Also, it would be good to clarify if the intention is to add yandex as default search engine, or just as one of them, and if you'd like to remove one of the existing ones in its favor.

Comment 2

[Selim Şumlu]

Sure.

First of all, Google will be kept as default, but we will be replacing Yahoo with Yandex.

Yandex has entered the Turkish market just last year, but they're playing really hard. Unlike Yahoo and Bing, they have a team working in Turkey, and they keep investing in the market.

Search results are much better than Yahoo (which is powered by Bing, and Bing's results don't work will in Turkish).

Other than search, they also have localized services similar to Google Street View and live traffic maps (not available in Google Turkey).

Last of all, we have asked our users via our community mailing list and our Twitter account whether they'd like to see Yandex or not. 39 out of 41 replies were positive.

Comment 3

[Kev Needham [:kev]]

Attachment: Patch to add Yandex and remove Yahoo! to Firefox in tr

Patch to add Yandex.com.tr as the number two search provider in the search bar. All values have been supplied by Yandex for use in Firefox.

Comment 4

[Kev Needham [:kev]]

Howdy folks. I don't have any objections to the change outlined in comment #0 given the rationale in comment #2. I've prepped the patch assuming the tr l10n team wants to make this so.

Axel/Milos, could you let me know who should review this patch for landing?

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 593186 [details] [diff] [review]
Patch to add Yandex and remove Yahoo! to Firefox in tr

Review of attachment 593186 [details] [diff] [review]:
-----------------------------------------------------------------

I'd like Selim to review this, in general and in particular for the Turkish strings in there.

There's the question about uil that makes me raise my technical eye brows, but the rest looks technically like what we want.

::: browser/searchplugins/yandex-tr.xml
@@ +25,5 @@
> +AAAAAAAAAQAAAAMAAAADAAAABwAAAA8AAA==</Image>
> +<Url type="application/x-suggestions+json" method="GET" template="http://suggest.yandex.com.tr/suggest-ff.cgi">
> +  <Param name="part" value="{searchTerms}"/>
> +  <Param name="uil" value="tr"/>
> +</Url>

We're only specifying uil (UI language, I guess) in this section, that tickles my spider senses.

Can you verify that this is only really wanted here, and required?

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 593186 [details] [diff] [review]
Patch to add Yandex and remove Yahoo! to Firefox in tr

Technically, this looks great, thanks for the patch.

With Selim's review and the uil question answered, that's an r=me.

Comment 7

[Kev Needham [:kev]]

Thanks, Axel. I'll double check with Yandex, but those were the parameters they specified. I suspect the search suggest runs off a common cluster (search host is not) and uil is used to ensure tr-specific results are sent (see host lookup below), but will ask for clarification.

squidlet:mozsrc kneedham$ host suggest.yandex.com.tr
suggest.yandex.com.tr is an alias for suggest.yandex.net.
suggest.yandex.net has address 87.250.250.63
suggest.yandex.net has address 87.250.251.63
suggest.yandex.net has address 213.180.204.63
suggest.yandex.net has address 77.88.21.63

Comment 8

[Axel Hecht [:Pike]]

... which is the same server the russian plugin uses, enough technical reasons for me.

Over to Selim.

Comment 9

[Selim Şumlu]

I've tested the XML file. Suggestions seem to be working fine, but the icon is broken (no icon in Firefox).

Can we also change the description to "Yandex Türkiye arama motoru" please?

Comment 10

[Selim Şumlu]

Comment on attachment 593186 [details] [diff] [review]
Patch to add Yandex and remove Yahoo! to Firefox in tr

Review of attachment 593186 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/searchplugins/yandex-tr.xml
@@ +1,3 @@
> +<SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/">
> +<ShortName>Yandex</ShortName>
> +<Description>İnternet'te aramak için Yandex'i kullanın.</Description>

Let's change this to "Yandex Türkiye arama motoru"

Comment 11

[Selim Şumlu]

Looks like I can't edit attachment flags. Is this a permission issue? Should I file a new bug about this?

Comment 12

[Axel Hecht [:Pike]]

Updated your priviledges, should work now.

Comment 13

[Selim Şumlu]

Attachment: Patch to add Yandex and remove Yahoo! to Firefox in tr

I'm just updating the description for Yandex.

Alex and Kev, I believe I don't have privilages to request a review, so please take this update into consideration.

Comment 14

[Kev Needham [:kev]]

Comment on attachment 596653 [details] [diff] [review]
Patch to add Yandex and remove Yahoo! to Firefox in tr

Verified with Yandex, and the modified longname is good to go.

Milos, can you do a final review, and then maybe we can land this?

Thanks all.

Comment 15

[Milos Dinic [:Milos]]

Comment on attachment 596653 [details] [diff] [review]
Patch to add Yandex and remove Yahoo! to Firefox in tr

Review of attachment 596653 [details] [diff] [review]:
-----------------------------------------------------------------

r-, for two reasons:

1) Yandex icon is not showing up
2) It looks like you emptied, but not removed the yahoo.tr file

Comment 16

[Axel Hecht [:Pike]]

Comment on attachment 596653 [details] [diff] [review]
Patch to add Yandex and remove Yahoo! to Firefox in tr

Review of attachment 596653 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, can't get the icon to work either, seems a weird list of characters for base64 encoding, too.

Comment 17

[Kev Needham [:kev]]

Attachment: Updated Yandex TR Search Plugin

Comment 18

[Kev Needham [:kev]]

Attachment: Patch to add Yandex, remove Yahoo! from TR defaults

Patch to address comment #15. Be great to get this landed as soon as possible to see if we can get into beta 2.

Comment 19

[Kev Needham [:kev]]

Attachment: Updated Patch to add Yandex, remove Yahoo! from defaults

Ok, that was weird, the attachment showed an old patch, not the one I submitted.

Comment 20

[Kev Needham [:kev]]

Attachment: Updated Patch to add Yandex, remove Yahoo! from defaults

Not sure what's going on. Bugzilla keeps showing an old patch. Last try, then I'll mail it directly.

Comment 21

[Axel Hecht [:Pike]]

Comment on attachment 605344 [details] [diff] [review]
Updated Patch to add Yandex, remove Yahoo! from defaults

Review of attachment 605344 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 22

[Milos Dinic [:Milos]]

Comment on attachment 605344 [details] [diff] [review]
Updated Patch to add Yandex, remove Yahoo! from defaults

Review of attachment 605344 [details] [diff] [review]:
-----------------------------------------------------------------

This one looks good. r+

Comment 23

[Kev Needham [:kev]]

Who needs to land this?

Comment 24

[Rail Aliiev [:rail]]

I can land it. Is there anything else to be done/checked?

Comment 25

[Axel Hecht [:Pike]]

Nope, this is good to land, thanks.

Comment 26

[Rail Aliiev [:rail]]

Comment on attachment 605344 [details] [diff] [review]
Updated Patch to add Yandex, remove Yahoo! from defaults

Pushed:
http://hg.mozilla.org/l10n-central/tr/rev/ca7c3b6ed885
http://hg.mozilla.org/releases/l10n/mozilla-aurora/tr/rev/75c6b7622436
http://hg.mozilla.org/releases/l10n/mozilla-beta/tr/rev/0632e3e54582