718020 - test_bug583889.html: "Error: uncaught exception: [object StopIteration]"

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[Serge Gautherie (:sgautherie)]

(While working on bug 717868 comment 3,)
I noticed the following error in (SeaMonkey) Error Console:
{
Error: uncaught exception: [object StopIteration]
}

https://developer.mozilla.org/en/JavaScript/Guide/Iterators_and_Generators#section_3
{
When either the end of the function or a return statement is reached, a StopIteration exception is thrown.
}

Code is:
{
41   SimpleTest.finish();
42   yield;
43 }
}
I don't know much about generators...
Should these be replaced by "SimpleTest.executeSoon(SimpleTest.finish);"?

*****

Cameron, should/could (not) this be caught+reported by bug 652494 + bug 703176 ?

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) test_bug583889.html: Delay "SimpleTest.finish()" call, Add missing 'yield' in bug583889_inner1.html, Add documentation [Checked in: Comment 6]

Please, check added documentation, as I +/- guessed test logic.


(In reply to Serge Gautherie (:sgautherie) from comment #0)

> Should these be replaced by "SimpleTest.executeSoon(SimpleTest.finish);"?

Not required, but helps to separate tests.

> *****
> 
> Cameron, should/could (not) this be caught+reported by bug 652494 + bug
> 703176 ?

I assume the case here is +/- that no (custom) window.onerror is attached to inner iframe(s).
We can't do anything about it, can we?
(Unless checking Error Console output :-/)

Comment 2

[Serge Gautherie (:sgautherie)]

(In reply to Serge Gautherie (:sgautherie) from comment #1)
> > Cameron, should/could (not) this be caught+reported by bug 652494 + bug
> > 703176 ?
> 
> I assume the case here is +/- that no (custom) window.onerror is attached to
> inner iframe(s).
> We can't do anything about it, can we?
> (Unless checking Error Console output :-/)

I filed bug 718205.

Comment 3

[Serge Gautherie (:sgautherie)]

Ping for review.

Comment 4

[Serge Gautherie (:sgautherie)]

Ping for review.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 588506 [details] [diff] [review]
(Av1) test_bug583889.html: Delay "SimpleTest.finish()" call, Add missing 'yield' in bug583889_inner1.html, Add documentation
[Checked in: Comment 6]

I'm not a good reviewer for this

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 588506 [details] [diff] [review]
(Av1) test_bug583889.html: Delay "SimpleTest.finish()" call, Add missing 'yield' in bug583889_inner1.html, Add documentation
[Checked in: Comment 6]

https://hg.mozilla.org/mozilla-central/rev/334d8674cdb6

Comment 7

[Serge Gautherie (:sgautherie)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=9364203&tree=Firefox&full=1
Rev3 Fedora 12 mozilla-central debug test mochitests-4/5 on 2012-02-15 12:58:42 PST for push 334d8674cdb6

V.Fixed