test_bug583889.html: "Error: uncaught exception: [object StopIteration]"

VERIFIED FIXED in mozilla13

Status

()

Core
Layout
P3
minor
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

(Depends on: 1 bug)

Trunk
mozilla13
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox10 wontfix, firefox11 wontfix, firefox12 wontfix, firefox-esr10 affected)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
(While working on bug 717868 comment 3,)
I noticed the following error in (SeaMonkey) Error Console:
{
Error: uncaught exception: [object StopIteration]
}

https://developer.mozilla.org/en/JavaScript/Guide/Iterators_and_Generators#section_3
{
When either the end of the function or a return statement is reached, a StopIteration exception is thrown.
}

Code is:
{
41   SimpleTest.finish();
42   yield;
43 }
}
I don't know much about generators...
Should these be replaced by "SimpleTest.executeSoon(SimpleTest.finish);"?

*****

Cameron, should/could (not) this be caught+reported by bug 652494 + bug 703176 ?
(Assignee)

Comment 1

5 years ago
Created attachment 588506 [details] [diff] [review]
(Av1) test_bug583889.html: Delay "SimpleTest.finish()" call, Add missing 'yield' in bug583889_inner1.html, Add documentation
[Checked in: Comment 6]

Please, check added documentation, as I +/- guessed test logic.


(In reply to Serge Gautherie (:sgautherie) from comment #0)

> Should these be replaced by "SimpleTest.executeSoon(SimpleTest.finish);"?

Not required, but helps to separate tests.

> *****
> 
> Cameron, should/could (not) this be caught+reported by bug 652494 + bug
> 703176 ?

I assume the case here is +/- that no (custom) window.onerror is attached to inner iframe(s).
We can't do anything about it, can we?
(Unless checking Error Console output :-/)
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #588506 - Flags: review?(jonas)
(Assignee)

Updated

5 years ago
Depends on: 718205
(Assignee)

Comment 2

5 years ago
(In reply to Serge Gautherie (:sgautherie) from comment #1)
> > Cameron, should/could (not) this be caught+reported by bug 652494 + bug
> > 703176 ?
> 
> I assume the case here is +/- that no (custom) window.onerror is attached to
> inner iframe(s).
> We can't do anything about it, can we?
> (Unless checking Error Console output :-/)

I filed bug 718205.
(Assignee)

Updated

5 years ago
Severity: normal → minor
Priority: -- → P3
(Assignee)

Comment 3

5 years ago
Ping for review.
(Assignee)

Comment 4

5 years ago
Ping for review.
(Assignee)

Updated

5 years ago
Attachment #588506 - Flags: review?(dbaron)
Comment on attachment 588506 [details] [diff] [review]
(Av1) test_bug583889.html: Delay "SimpleTest.finish()" call, Add missing 'yield' in bug583889_inner1.html, Add documentation
[Checked in: Comment 6]

I'm not a good reviewer for this
Attachment #588506 - Flags: review?(dbaron) → review?
(Assignee)

Updated

5 years ago
Attachment #588506 - Flags: review? → review?(roc)
Attachment #588506 - Flags: review?(roc) → review+
(Assignee)

Comment 6

5 years ago
Comment on attachment 588506 [details] [diff] [review]
(Av1) test_bug583889.html: Delay "SimpleTest.finish()" call, Add missing 'yield' in bug583889_inner1.html, Add documentation
[Checked in: Comment 6]

https://hg.mozilla.org/mozilla-central/rev/334d8674cdb6
Attachment #588506 - Attachment description: (Av1) test_bug583889.html: Delay "SimpleTest.finish()" call, Add missing 'yield' in bug583889_inner1.html, Add documentation → (Av1) test_bug583889.html: Delay "SimpleTest.finish()" call, Add missing 'yield' in bug583889_inner1.html, Add documentation [Checked in: Comment 6]
Attachment #588506 - Flags: review?(jonas)
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
status-firefox-esr10: --- → affected
status-firefox10: --- → wontfix
status-firefox11: --- → wontfix
status-firefox12: --- → wontfix
Flags: in-testsuite+
OS: Windows 2000 → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
(Assignee)

Comment 7

5 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=9364203&tree=Firefox&full=1
Rev3 Fedora 12 mozilla-central debug test mochitests-4/5 on 2012-02-15 12:58:42 PST for push 334d8674cdb6

V.Fixed
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.