718056 - /current/versions service not being cached

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[Robert Helmer [:rhelmer]]

Looks like every Socorro page is doing a request for the CurrentVersions service. The branch model is doing:

$resp = $service->get("${host}/current/versions/${from}");

But looking at the Web_Service->get() method, it won't cache the result unless we pass another arg, $cache_lifetime (default is null)

Comment 1

[Lonnen :lonnen]

rhelmer: r?
https://github.com/mozilla/socorro/pull/280

I used ` tail /var/log/apach2/other_vhosts_access.log | grep "bpapi" ` to verify in vagrant, looking to make sure api calls were made after any action to invalidate and that browsing following that kept current/versions/{opts} cached. There are some variants on {opts}, so you may see up to 3 /current/versions/ calls after a change but otherwise the cache should handle it.

This introduces a config change.

Comment 2

[[github robot]]

Commits pushed to https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/1fd1dd53cbcba1304871cf2ce15f8f3d73c537cd
bug 718056 - add configurable cache to the branch model

https://github.com/mozilla/socorro/commit/ba671f8e2afc7b225161ba8ef46ab2c5c72b227b
Merge pull request #280 from Lonnen/718056-branch-cache

bug 718056 - add configurable cache to the branch model

Comment 3

[[github robot]]

Commit pushed to https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/fbf1e89d469c025aebec325b864954aeb91d9fcb
bug 718056 - add configurable cache to the branch model

Comment 4

[[github robot]]

Commits pushed to https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/0b2c634cc6f5100760335aeed822149e7230d235
bug 718056 - typo in config file

https://github.com/mozilla/socorro/commit/f1ab46b84b25b1167e0d9c823d8e92d4685cc347
Merge pull request #282 from Lonnen/718056-branch-cache-redux

bug 718056 - typo in config file

Comment 5

[[github robot]]

Commit pushed to https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/8706bd6300db72cd37502b3c3fc2bc756d3b5e74
bug 718056 - typo in config file

Comment 6

[Laura Thomson :laura]

What's the status here?  Should this move to 2.4.1 or are we going to ship a 2.4.0.1?

Comment 7

[Robert Helmer [:rhelmer]]

(In reply to Laura Thomson :laura from comment #6)
> What's the status here?  Should this move to 2.4.1 or are we going to ship a
> 2.4.0.1?

Oops, status is that this was fixed and pushed with 2.4 - forgot to mark resolved apparently. We confirmed on prod that this is now working.