Closed Bug 718072 Opened 8 years ago Closed 8 years ago

WeakMaps constructor doesn't always get initialized on the global object

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(1 file)

My spidey senses tell me that we could use some consolidation here. But in the mean time, here's the patch.
Attached patch patch v1Splinter Review
Attachment #588528 - Flags: review?(jwalden+bmo)
Comment on attachment 588528 [details] [diff] [review]
patch v1

Review of attachment 588528 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/GlobalObject.cpp
@@ +49,5 @@
>  #include "frontend/BytecodeEmitter.h"
>  #include "vm/GlobalObject-inl.h"
>  
>  #include "jsobjinlines.h"
> +#include "jsweakmap.h"

Could you insert this in the js* non-inlines list above?  The current inclusions look a disordered mess, but that's no reason to compound the problem.
Attachment #588528 - Flags: review?(jwalden+bmo) → review+
Pushed to inbound: http://hg.mozilla.org/integration/mozilla-inbound/rev/5bc8dcf80474
Assignee: general → bobbyholley+bmo
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/5bc8dcf80474
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Duplicate of this bug: 697928
You need to log in before you can comment on or make changes to this bug.