The default bug view has changed. See this FAQ.

Remove keyboard shortcuts for zooming to 1:1 scale when viewing standalone images

RESOLVED FIXED in mozilla12

Status

()

Core
Layout: Images
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jaws, Assigned: diogogmt)

Tracking

Trunk
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=jwein][lang=c++])

Attachments

(1 attachment, 1 obsolete attachment)

There exists two keyboard shortcuts, shift+plus and minus, to scale a shrink-to-fit image to 1:1 scale and back. These shortcuts are extremely hidden and exist at a cost of maintainability to ImageDocument.

We should just remove these shortcuts, since users can already do ctrl+plus and ctrl+minus to zoom in and out of the image.
Whiteboard: [mentor=jwein][lang=c++]
Created attachment 588586 [details] [diff] [review]
Removed shortchut Shift+plus/minus for zooming image to 1:1 scale
Comment on attachment 588586 [details] [diff] [review]
Removed shortchut Shift+plus/minus for zooming image to 1:1 scale

Review of attachment 588586 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Diogo! I've passed the patch on to review from Robert O'Callahan. Can you also follow the steps in Marco's blog post and update your patch to have a user line as well as a summary?
Attachment #588586 - Flags: review?(roc)
Attachment #588586 - Flags: feedback+
Created attachment 588597 [details] [diff] [review]
Patch v2
Attachment #588586 - Attachment is obsolete: true
Attachment #588586 - Flags: review?(roc)
Attachment #588597 - Flags: review+
https://hg.mozilla.org/integration/fx-team/rev/2cba23414a5c

Congratulations on your first patch Diogo!
Whiteboard: [mentor=jwein][lang=c++] → [mentor=jwein][lang=c++][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/2cba23414a5c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [mentor=jwein][lang=c++][fixed-in-fx-team] → [mentor=jwein][lang=c++]
Target Milestone: --- → mozilla12
(In reply to Jared Wein [:jwein and :jaws] from comment #4)
> https://hg.mozilla.org/integration/fx-team/rev/2cba23414a5c
> 
> Congratulations on your first patch Diogo!

Thanks a lot for the help Jared :)
You need to log in before you can comment on or make changes to this bug.