718133 - Remove keyboard shortcuts for zooming to 1:1 scale when viewing standalone images

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

There exists two keyboard shortcuts, shift+plus and minus, to scale a shrink-to-fit image to 1:1 scale and back. These shortcuts are extremely hidden and exist at a cost of maintainability to ImageDocument.

We should just remove these shortcuts, since users can already do ctrl+plus and ctrl+minus to zoom in and out of the image.

Comment 1

[Diogo Golovanevsky Monteiro [:diogogmt]]

Attachment: Removed shortchut Shift+plus/minus for zooming image to 1:1 scale

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 588586 [details] [diff] [review]
Removed shortchut Shift+plus/minus for zooming image to 1:1 scale

Review of attachment 588586 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Diogo! I've passed the patch on to review from Robert O'Callahan. Can you also follow the steps in Marco's blog post and update your patch to have a user line as well as a summary?

Comment 3

[Diogo Golovanevsky Monteiro [:diogogmt]]

Attachment: Patch v2

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/fx-team/rev/2cba23414a5c

Congratulations on your first patch Diogo!

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/2cba23414a5c

Comment 6

[Diogo Golovanevsky Monteiro [:diogogmt]]

(In reply to Jared Wein [:jwein and :jaws] from comment #4)
> https://hg.mozilla.org/integration/fx-team/rev/2cba23414a5c
> 
> Congratulations on your first patch Diogo!

Thanks a lot for the help Jared :)