Last Comment Bug 718150 - Shadow layer Swap() implementations for images and canvas don't work correctly the first time
: Shadow layer Swap() implementations for images and canvas don't work correctl...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: mozilla12
Assigned To: Boris Zbarsky [:bz]
:
Mentors:
Depends on:
Blocks: 598482
  Show dependency treegraph
 
Reported: 2012-01-13 20:51 PST by Boris Zbarsky [:bz]
Modified: 2012-01-19 10:55 PST (History)
4 users (show)
bzbarsky: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Make sure to update our stored size on Swap() even if we didn't already have a front surface. (2.62 KB, patch)
2012-01-13 20:54 PST, Boris Zbarsky [:bz]
cjones.bugs: review+
Details | Diff | Splinter Review

Description Boris Zbarsky [:bz] 2012-01-13 20:51:07 PST
In particular, the first Swap() call has an invalid front surface (of course), but we end up not updating mBounds as a result.  That means that if there are no more Swap() calls we won't paint correctly.
Comment 1 Boris Zbarsky [:bz] 2012-01-13 20:54:22 PST
Created attachment 588593 [details] [diff] [review]
Make sure to update our stored size on Swap() even if we didn't already have a front surface.
Comment 3 Jonathan Kew (:jfkthame) 2012-01-16 04:57:25 PST
https://hg.mozilla.org/mozilla-central/rev/da960aeaf4bf

Note You need to log in before you can comment on or make changes to this bug.