Dehydra fails to build against the javascript engine in FF10esr

RESOLVED WONTFIX

Status

Firefox Build System
Source Code Analysis
RESOLVED WONTFIX
7 years ago
3 months ago

People

(Reporter: glandium, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
dehydra_ast.c: In function 'dehydra_makeVar':
dehydra_ast.c:51:21: error: invalid operands to binary == (have 'jsval' and 'jsval')
dehydra_ast.c: In function 'dehydra_initVar':
dehydra_ast.c:127:11: error: invalid operands to binary == (have 'jsval' and 'jsval')
This is just the tip of the iceberg; there's several more in several files. Basically, we need to

s/\([a-z_]*\) == JSVAL_VOID/JSVAL_IS_VOID(\1)/g
s/\([a-z_]*\) != JSVAL_VOID/!JSVAL_IS_VOID(\1)/g
s/\([a-z_]*\) == JSVAL_TRUE/JSVAL_TO_BOOLEAN(\1) == JS_TRUE/g

[and maybe a few others; I'm using trunk spidermonkey right now which... has even more failures]
(Reporter)

Comment 2

6 years ago
Considering bug 735599, 10esr should be a baseline we need to keep building against.
Summary: Dehydra fails to build against the javascript engine in FF9 → Dehydra fails to build against the javascript engine in FF10esr
(Reporter)

Comment 3

6 years ago
Created attachment 612851 [details] [diff] [review]
Patch v1

With the patch I get the following:

python unit_test_harness.py dehydra "/usr/bin/g++-4.6"
..................xx...................................................
Test Failure: 
    Test command: /usr/bin/gcc-4.6 -c -fplugin=../gcc_dehydra.so -o /dev/null -fplugin-arg-gcc_dehydra-script=test_strict.js onefunc.cc
    Failure msg: Expected 'OK' output; Errors:
 ../libs/xhydra.js:52: JS STRICTJS Exception: ReferenceError: reference to undefined property this._loc
../libs/xhydra.js:52:	#0: print("OK")
./test_strict.js:12:	#1: process_function([object DehydraDecl],[object Array])

Test Failure: 
    Test command: /usr/bin/g++-4.6 -c -fplugin=../gcc_dehydra.so -o /dev/null -fplugin-arg-gcc_dehydra-script=test_strict.js onefunc.cc
    Failure msg: Expected 'OK' output; Errors:
 ../libs/xhydra.js:52: JS STRICTJS Exception: ReferenceError: reference to undefined property this._loc
../libs/xhydra.js:52:	#0: print("OK")
./test_strict.js:12:	#1: process_function([object DehydraDecl],[object Array])


Unit Test Suite Summary:
     69 passed
      2 failed
      0 error(s)

Not sure how to debug this.
Assignee: nobody → mh+mozilla
(Reporter)

Updated

5 years ago
Assignee: mh+mozilla → nobody
Dehydra and treehydra are no longer maintained by Mozilla.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WONTFIX

Updated

3 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.