718189 - Don't expose source-home-page as a synchronous getter

Status: RESOLVED INVALID

(Firefox :: Migration, defect)

Description

[Asaf Romano (gone)]

nsIBrowserProfileMigrator's sourceHomePageURL attribute requires migratros to retrieve it synchronously. This is not so great, and for the safari profile migrator, it also forces us to expose a sync reader in property-list-utils.

Comment 1

[Matthew N. [:MattN]]

It's also profile-related so I'd prefer if it was a function with an aProfile argument like most others so that the migrator doesn't have to remember the profile that is being migrated.

Comment 2

[Asaf Romano (gone)]

Fixing this properly requires asyncifying getResources, because the migration wizard wants to know if the source homepage is indeed set (and to a "valid" value), not just if it /could/ be set (which is what we do now for other resources: we check for files existence).

Comment 3

[Asaf Romano (gone)]

And this is tricky because ProfileMigrator.migrate needs sourceProfiles and getResources to work synchronously, because it must open the (modal) wizard before the it returns. Otherwise, the browser window will show up.

So, it seems this cannot be made a proper resource. However, the new async function, replacing the current getter, can sure take care of the profiles issues raised in comment 1.

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Bug 1434167 made this invalid