718210 - spdy hdr decompress context screwed up by server push

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Patrick McManus [:mcmanus]]

node-spdy is the first backend to implement server push. right now we rst any pushed streams, but we need to decompress the headers in those push frames so that the decompress context stays in sync with the sender. confirmed that interop continues with the patch attached to this bug.

Comment 1

[Patrick McManus [:mcmanus]]

Attachment: patch 0

Hi honza, this is an interop issue so I'd like to expedite it to whatever extent possible.. might even nom for aurora.

Comment 2

[Fedor Indutny]

Btw, supporting push streams would be cool feature too :)

Comment 3

[Patrick McManus [:mcmanus]]

(In reply to Fedor Indutny from comment #2)
> Btw, supporting push streams would be cool feature too :)

yes - just a few things to sort out to make sure there isn't room for cache poisoning attacks and so on..

Comment 4

[Honza Bambas (:mayhemer)]

Comment on attachment 588668 [details] [diff] [review]
patch 0

Review of attachment 588668 [details] [diff] [review]:
-----------------------------------------------------------------

Ups.. I didn't catch this even during the review (almost done by this time, btw).

r=honzab

For channel drivers: this is patch for a bug in a feature that is by default pref'ed off but people out there are testing it by manually pref'ing it on (including my self).  So it would be helpful and harmless to land it on aurora as well.

::: netwerk/protocol/http/SpdySession.cpp
@@ +776,5 @@
>  {
>    NS_ABORT_IF_FALSE(self->mFrameControlType == CONTROL_TYPE_SYN_STREAM,
>                      "wrong control type");
>    
> +  if (self->mFrameDataSize < 18) {

Hmm.. a bug in the spec apparently.

Comment 5

[Patrick McManus [:mcmanus]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/59cb54c6dfe1

Comment 6

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/mozilla-central/rev/59cb54c6dfe1

Comment 7

[u279076]

Is this something QA can verify?