Last Comment Bug 718253 - (carnitas) Critical omission from en-us spelling dictionary
(carnitas)
: Critical omission from en-us spelling dictionary
Status: RESOLVED FIXED
[pork]
:
Product: Core
Classification: Components
Component: Spelling checker (show other bugs)
: Trunk
: All All
: -- normal with 2 votes (vote)
: mozilla12
Assigned To: Justin Dolske [:Dolske]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-14 18:56 PST by Justin Dolske [:Dolske]
Modified: 2012-06-22 06:49 PDT (History)
11 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v.1 (7.76 KB, patch)
2012-01-21 19:41 PST, Justin Dolske [:Dolske]
ehsan: review-
Details | Diff | Splinter Review
Patch v.2 (8.33 KB, patch)
2012-01-25 17:47 PST, Justin Dolske [:Dolske]
ehsan: review+
Details | Diff | Splinter Review

Description Justin Dolske [:Dolske] 2012-01-14 18:56:18 PST
Holy molé. How can it be possible that our spell checker does not recognize "carnitas"?! I might take some ribbing for this, but I consider it an hamergency. Lard almighty...
Comment 1 Rob Campbell [:rc] (:robcee) 2012-01-16 10:59:48 PST
Well barbecue my hamhocks! This will not stand! This is an outrage! Surely this word is in general usage and not an intentional omission. Carnitas are a nepenthe of oneiric capabilities and require reinclusion in our anglic omnibus!
Comment 2 :Ehsan Akhgari 2012-01-16 11:12:20 PST
See <https://developer.mozilla.org/en-US/Adding_a_new_word_to_the_en-US_dictionary> as a guide about how this word should be added.
Comment 3 Dan Mills [:thunder] 2012-01-19 23:32:25 PST
<3
Comment 4 Justin Dolske [:Dolske] 2012-01-21 19:36:44 PST
(In reply to Ehsan Akhgari [:ehsan] from comment #2)
> See
> <https://developer.mozilla.org/en-US/Adding_a_new_word_to_the_en-
> US_dictionary> as a guide about how this word should be added.

Where can I learn about the formatting of this file?

I've added as such:

...
carnality/M
carnation/IMS
carnelian/MS
carney/MS
carnitas
carnival/MS
carnivore/SM
carnivorous/YP
...

I _think_ this is minimally ok without the "/XYZ" stuff (there are other such entries), but I do wonder what it does. Presumably some kind of automation for plurals / suffixes?

(Also, does order matter, and/or do the scripts ensure that?)
Comment 5 Justin Dolske [:Dolske] 2012-01-21 19:41:58 PST
Created attachment 590535 [details] [diff] [review]
Patch v.1

Seems surprising that this not only added the new word, but changed the "/XYZ" stuff for a number of following words. Not sure what's going on.
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-01-22 06:05:42 PST
The /XYZ stuff is controlled by the affix file in the same directory. Otherwise, you (correctly) took a diff of a diff. It's not surprising that things moved around a bit with a new addition.
Comment 7 :Ehsan Akhgari 2012-01-23 12:47:33 PST
Comment on attachment 590535 [details] [diff] [review]
Patch v.1

Seems like you missed the last step in the instructions (moving en-US.dic.)  ;-)
Comment 8 Justin Dolske [:Dolske] 2012-01-25 17:47:24 PST
Created attachment 591669 [details] [diff] [review]
Patch v.2

Sow-wy. I read the whole page this time, I think.
Comment 9 Mozilla RelEng Bot 2012-01-30 06:45:47 PST
Autoland Patchset:
	Patches: 591669
	Branch: mozilla-central => try
	Destination: ssh://hg.mozilla.org/try
Try run started, revision a9d48b6cdf69. To cancel or monitor the job, see: https://build.mozilla.org/buildapi/self-serve/try/rev/a9d48b6cdf69
Comment 10 Mozilla RelEng Bot 2012-01-30 11:00:35 PST
Try run for a9d48b6cdf69 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=a9d48b6cdf69
Results (out of 206 total builds):
    exception: 1
    success: 182
    warnings: 23
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-a9d48b6cdf69
Comment 12 Ed Morley [:emorley] 2012-01-31 07:00:27 PST
https://hg.mozilla.org/mozilla-central/rev/e42e07e4f668

Note You need to log in before you can comment on or make changes to this bug.