The default bug view has changed. See this FAQ.
Bug 718253 (carnitas)

Critical omission from en-us spelling dictionary

RESOLVED FIXED in mozilla12

Status

()

Core
Spelling checker
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Dolske, Assigned: Dolske)

Tracking

Trunk
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [pork])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Holy molé. How can it be possible that our spell checker does not recognize "carnitas"?! I might take some ribbing for this, but I consider it an hamergency. Lard almighty...
Well barbecue my hamhocks! This will not stand! This is an outrage! Surely this word is in general usage and not an intentional omission. Carnitas are a nepenthe of oneiric capabilities and require reinclusion in our anglic omnibus!
See <https://developer.mozilla.org/en-US/Adding_a_new_word_to_the_en-US_dictionary> as a guide about how this word should be added.
Whiteboard: [pork] → [pork][mentor=ehsan]

Comment 3

5 years ago
<3
(Assignee)

Comment 4

5 years ago
(In reply to Ehsan Akhgari [:ehsan] from comment #2)
> See
> <https://developer.mozilla.org/en-US/Adding_a_new_word_to_the_en-
> US_dictionary> as a guide about how this word should be added.

Where can I learn about the formatting of this file?

I've added as such:

...
carnality/M
carnation/IMS
carnelian/MS
carney/MS
carnitas
carnival/MS
carnivore/SM
carnivorous/YP
...

I _think_ this is minimally ok without the "/XYZ" stuff (there are other such entries), but I do wonder what it does. Presumably some kind of automation for plurals / suffixes?

(Also, does order matter, and/or do the scripts ensure that?)
(Assignee)

Comment 5

5 years ago
Created attachment 590535 [details] [diff] [review]
Patch v.1

Seems surprising that this not only added the new word, but changed the "/XYZ" stuff for a number of following words. Not sure what's going on.
Assignee: nobody → dolske
Attachment #590535 - Flags: review?(ehsan)
The /XYZ stuff is controlled by the affix file in the same directory. Otherwise, you (correctly) took a diff of a diff. It's not surprising that things moved around a bit with a new addition.
Comment on attachment 590535 [details] [diff] [review]
Patch v.1

Seems like you missed the last step in the instructions (moving en-US.dic.)  ;-)
Attachment #590535 - Flags: review?(ehsan) → review-
(Assignee)

Comment 8

5 years ago
Created attachment 591669 [details] [diff] [review]
Patch v.2

Sow-wy. I read the whole page this time, I think.
Attachment #590535 - Attachment is obsolete: true
Attachment #591669 - Flags: review?(ehsan)

Updated

5 years ago
Attachment #591669 - Attachment is patch: true
Attachment #591669 - Flags: review?(ehsan) → review+

Updated

5 years ago
Whiteboard: [pork][mentor=ehsan] → [pork][autoland]

Updated

5 years ago
Whiteboard: [pork][autoland] → [pork][autoland-in-queue]

Comment 9

5 years ago
Autoland Patchset:
	Patches: 591669
	Branch: mozilla-central => try
	Destination: ssh://hg.mozilla.org/try
Try run started, revision a9d48b6cdf69. To cancel or monitor the job, see: https://build.mozilla.org/buildapi/self-serve/try/rev/a9d48b6cdf69

Comment 10

5 years ago
Try run for a9d48b6cdf69 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=a9d48b6cdf69
Results (out of 206 total builds):
    exception: 1
    success: 182
    warnings: 23
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-a9d48b6cdf69

Updated

5 years ago
Whiteboard: [pork][autoland-in-queue] → [pork]
(Assignee)

Comment 11

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/e42e07e4f668
https://hg.mozilla.org/mozilla-central/rev/e42e07e4f668
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.