718253 - (carnitas) Critical omission from en-us spelling dictionary

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Justin Dolske [:Dolske]]

Holy molé. How can it be possible that our spell checker does not recognize "carnitas"?! I might take some ribbing for this, but I consider it an hamergency. Lard almighty...

Comment 1

[Rob Campbell [:rc] (:robcee)]

Well barbecue my hamhocks! This will not stand! This is an outrage! Surely this word is in general usage and not an intentional omission. Carnitas are a nepenthe of oneiric capabilities and require reinclusion in our anglic omnibus!

Comment 2

[(no longer active)]

See <https://developer.mozilla.org/en-US/Adding_a_new_word_to_the_en-US_dictionary> as a guide about how this word should be added.

Comment 3

[Dan Mills [:thunder]]

<3

Comment 4

[Justin Dolske [:Dolske]]

(In reply to Ehsan Akhgari [:ehsan] from comment #2)
> See
> <https://developer.mozilla.org/en-US/Adding_a_new_word_to_the_en-
> US_dictionary> as a guide about how this word should be added.

Where can I learn about the formatting of this file?

I've added as such:

...
carnality/M
carnation/IMS
carnelian/MS
carney/MS
carnitas
carnival/MS
carnivore/SM
carnivorous/YP
...

I _think_ this is minimally ok without the "/XYZ" stuff (there are other such entries), but I do wonder what it does. Presumably some kind of automation for plurals / suffixes?

(Also, does order matter, and/or do the scripts ensure that?)

Comment 5

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

Seems surprising that this not only added the new word, but changed the "/XYZ" stuff for a number of following words. Not sure what's going on.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

The /XYZ stuff is controlled by the affix file in the same directory. Otherwise, you (correctly) took a diff of a diff. It's not surprising that things moved around a bit with a new addition.

Comment 7

[(no longer active)]

Comment on attachment 590535 [details] [diff] [review]
Patch v.1

Seems like you missed the last step in the instructions (moving en-US.dic.)  ;-)

Comment 8

[Justin Dolske [:Dolske]]

Attachment: Patch v.2

Sow-wy. I read the whole page this time, I think.

Comment 9

[Mozilla RelEng Bot]

Autoland Patchset:
	Patches: 591669
	Branch: mozilla-central => try
	Destination: ssh://hg.mozilla.org/try
Try run started, revision a9d48b6cdf69. To cancel or monitor the job, see: https://build.mozilla.org/buildapi/self-serve/try/rev/a9d48b6cdf69

Comment 10

[Mozilla RelEng Bot]

Try run for a9d48b6cdf69 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=a9d48b6cdf69
Results (out of 206 total builds):
    exception: 1
    success: 182
    warnings: 23
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-a9d48b6cdf69

Comment 11

[Justin Dolske [:Dolske]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/e42e07e4f668

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e42e07e4f668