Last Comment Bug 718254 - IPDL unit test harness doesn't compile
: IPDL unit test harness doesn't compile
Status: RESOLVED FIXED
[inbound]
:
Product: Core
Classification: Components
Component: IPC (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla13
Assigned To: Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-14 19:32 PST by Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
Modified: 2012-02-03 11:50 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Get the IPDL unit test harness compiling again (3.15 KB, patch)
2012-01-14 19:33 PST, Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
bent.mozilla: review+
Details | Diff | Splinter Review

Description Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-01-14 19:32:15 PST
IPDLUnitTests.cpp
/home/cjones/mozilla/ff-dbg/ipc/ipdl/test/cxx/IPDLUnitTests.cpp:61: error: ‘mozilla::_ipdltest::gChildThread’ should have been declared inside ‘mozilla::_ipdltest’
/home/cjones/mozilla/ff-dbg/ipc/ipdl/test/cxx/IPDLUnitTests.cpp: In function ‘const char* const mozilla::_ipdltest::IPDLUnitTestName()’:
/home/cjones/mozilla/ff-dbg/ipc/ipdl/test/cxx/IPDLUnitTests.cpp:88: error: call of overloaded ‘moz_strdup(const char*)’ is ambiguous
../../../../dist/include/mozilla/mozalloc.h:133: note: candidates are: char* moz_strdup(const char*)
/home/cjones/mozilla/mozilla-central/ipc/chromium/src/base/string_util_posix.h:19: note:                 char* base::moz_strdup(const char*)
/home/cjones/mozilla/ff-dbg/ipc/ipdl/test/cxx/IPDLUnitTests.cpp: In function ‘void mozilla::_ipdltest::IPDLUnitTestMain(void*)’:
/home/cjones/mozilla/ff-dbg/ipc/ipdl/test/cxx/IPDLUnitTests.cpp:591: error: ‘RunTestInProcesses’ is not a member of ‘mozilla::_ipdltest::TestSysVShmemParent’
/home/cjones/mozilla/ff-dbg/ipc/ipdl/test/cxx/IPDLUnitTests.cpp: In function ‘void mozilla::_ipdltest::IPDLUnitTestThreadMain(char*)’:
/home/cjones/mozilla/ff-dbg/ipc/ipdl/test/cxx/IPDLUnitTests.cpp:1137: error: ‘RunTestInThreads’ is not a member of ‘mozilla::_ipdltest::TestSysVShmemParent’
Comment 1 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-01-14 19:33:28 PST
Created attachment 588705 [details] [diff] [review]
Get the IPDL unit test harness compiling again
Comment 2 Ben Turner (not reading bugmail, use the needinfo flag!) 2012-01-15 09:22:09 PST
Comment on attachment 588705 [details] [diff] [review]
Get the IPDL unit test harness compiling again

Review of attachment 588705 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Comment 3 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-02-02 00:34:04 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/c925a45fcf5b
Comment 4 Ed Morley [:emorley] 2012-02-03 11:50:55 PST
https://hg.mozilla.org/mozilla-central/rev/c925a45fcf5b

Note You need to log in before you can comment on or make changes to this bug.