718254 - IPDL unit test harness doesn't compile

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

IPDLUnitTests.cpp
/home/cjones/mozilla/ff-dbg/ipc/ipdl/test/cxx/IPDLUnitTests.cpp:61: error: ‘mozilla::_ipdltest::gChildThread’ should have been declared inside ‘mozilla::_ipdltest’
/home/cjones/mozilla/ff-dbg/ipc/ipdl/test/cxx/IPDLUnitTests.cpp: In function ‘const char* const mozilla::_ipdltest::IPDLUnitTestName()’:
/home/cjones/mozilla/ff-dbg/ipc/ipdl/test/cxx/IPDLUnitTests.cpp:88: error: call of overloaded ‘moz_strdup(const char*)’ is ambiguous
../../../../dist/include/mozilla/mozalloc.h:133: note: candidates are: char* moz_strdup(const char*)
/home/cjones/mozilla/mozilla-central/ipc/chromium/src/base/string_util_posix.h:19: note:                 char* base::moz_strdup(const char*)
/home/cjones/mozilla/ff-dbg/ipc/ipdl/test/cxx/IPDLUnitTests.cpp: In function ‘void mozilla::_ipdltest::IPDLUnitTestMain(void*)’:
/home/cjones/mozilla/ff-dbg/ipc/ipdl/test/cxx/IPDLUnitTests.cpp:591: error: ‘RunTestInProcesses’ is not a member of ‘mozilla::_ipdltest::TestSysVShmemParent’
/home/cjones/mozilla/ff-dbg/ipc/ipdl/test/cxx/IPDLUnitTests.cpp: In function ‘void mozilla::_ipdltest::IPDLUnitTestThreadMain(char*)’:
/home/cjones/mozilla/ff-dbg/ipc/ipdl/test/cxx/IPDLUnitTests.cpp:1137: error: ‘RunTestInThreads’ is not a member of ‘mozilla::_ipdltest::TestSysVShmemParent’

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Get the IPDL unit test harness compiling again

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 588705 [details] [diff] [review]
Get the IPDL unit test harness compiling again

Review of attachment 588705 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c925a45fcf5b

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c925a45fcf5b