Closed Bug 718257 Opened 10 years ago Closed 10 years ago

Syntax error breaks add-on install restart doorhanger

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox11 fixed, firefox12 fixed, firefox13 verified, fennec11+)

Status:
VERIFIED FIXED
Milestone:
Firefox 12
Tracking Flags:
Tracking Status
firefox11 --- fixed
firefox12 --- fixed
firefox13 --- verified
fennec 11+ ---

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

patch
1.15 KB, patch
mbrubeck
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
Bug 717904 shows a bug in the restart process for add-on installation. A syntax error was breaking the display of the restart doorhanger. With this simple patch the doorhanger appears and will restart the app, if used.
Attachment #588710 - Flags: review?(mbrubeck)
tracking-fennec: --- → 11+
status-firefox11: --- → affected
status-firefox12: --- → affected
Attachment #588710 - Flags: review?(mbrubeck) → review+
https://hg.mozilla.org/mozilla-central/rev/fbf07f7e8c93
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Assignee: nobody → mark.finkle
Comment on attachment 588710 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
addon restart door hanger is broken
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
none, fixes typo
Attachment #588710 - Flags: approval-mozilla-aurora?
Comment on attachment 588710 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #588710 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified fixed on:
Nightly Fennec 13.0a1 (2012-03-06)
Device: HTC Desire Z
OS: Android 2.3.3
Status: RESOLVED → VERIFIED
status-firefox13: --- → verified
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.