Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Syntax error breaks add-on install restart doorhanger

VERIFIED FIXED in Firefox 11

Status

()

Product:
Firefox for Android
Component:
General
VERIFIED FIXED
Reported:
6 years ago
Modified:
5 years ago

People

(Reporter: mfinkle, Assigned: mfinkle)

Tracking

Version:
unspecified
Target:
Firefox 12
x86
Linux
Points:
---

Firefox Tracking Flags

(firefox11 fixed, firefox12 fixed, firefox13 verified, fennec11+)

Details

Attachments

(1 attachment)

patch
1.15 KB, patch
mbrubeck
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review
(Assignee)

Description

•
6 years ago 
Created attachment 588710 [details] [diff] [review]
patch

Bug 717904 shows a bug in the restart process for add-on installation. A syntax error was breaking the display of the restart doorhanger. With this simple patch the doorhanger appears and will restart the app, if used.
Attachment #588710 - Flags: review?(mbrubeck)
 (Assignee)

Updated

•
6 years ago
tracking-fennec: --- → 11+
status-firefox11: --- → affected
status-firefox12: --- → affected
Attachment #588710 - Flags: review?(mbrubeck) → review+
 (Assignee)

Comment 1

•
6 years ago 
https://hg.mozilla.org/integration/mozilla-inbound/rev/fbf07f7e8c93

Comment 2

•
6 years ago 
https://hg.mozilla.org/mozilla-central/rev/fbf07f7e8c93
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12

Updated

•
6 years ago
Assignee: nobody → mark.finkle

Comment 3

•
6 years ago 
Comment on attachment 588710 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
addon restart door hanger is broken
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
none, fixes typo
Attachment #588710 - Flags: approval-mozilla-aurora?

Comment 4

•
6 years ago 
Comment on attachment 588710 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #588710 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 5

•
6 years ago 
https://hg.mozilla.org/releases/mozilla-aurora/rev/24cb0e50df85
status-firefox11: affected → fixed
status-firefox12: affected → fixed

Comment 6

•
5 years ago 
Verified fixed on:
Nightly Fennec 13.0a1 (2012-03-06)
Device: HTC Desire Z
OS: Android 2.3.3
Status: RESOLVED → VERIFIED
status-firefox13: --- → verified
You need to log in before you can comment on or make changes to this bug.