Closed Bug 718268 Opened 10 years ago Closed 10 years ago

After closing tab, tab list scrolls back to the top

Categories

(Firefox for Android Graveyard :: General, defect, P3)

ARM
Android
defect

Tracking

(firefox13 verified, fennec+)

VERIFIED FIXED
Firefox 13
Tracking Status
firefox13 --- verified
fennec + ---

People

(Reporter: martijn.martijn, Assigned: sriram)

Details

(Whiteboard: tabs-ux)

Attachments

(1 file, 1 obsolete file)

Steps to reproduce:
- Open 8 tabs or more
- Open the tab list popup by tapping on the thing on the right of the url bar
- Select the last tab in the tab list
- Close the last tab

Expected result:
Last tab is closed, the second to last tab is the last tab now and is selected and in view.

Actual result:
Last tab is closed, the second to last tab is the last tab now and is selected, but is not in view. The tab list has scrolled to the beginning.
tracking-fennec: --- → +
Priority: -- → P3
Whiteboard: tabs-ux
Assignee: nobody → sriram
Attached patch Patch (obsolete) — Splinter Review
setSelection() (my bad, I didn't know about it) perfectly positions the view. Now that we know when a List is inflated (basically after requestLayout() on the ListContainer), we can safely do a setSelection() for the list.
This also solves the problem in Eclair.

Also, closing Tab 1 when Tab 6 (obscured from the view) is the selected tab, should not scroll the list to Tab 6. The mScrollToSelectedTab flag takes care of the same.
Attachment #595217 - Flags: review?(mark.finkle)
I think there is a problem with this patch. If there are 10 tabs with tabs 4-6 shown to the user, and user closes tab 5, it still scrolls to the top.
Do we really want to show tabs 4,6,7 to the user? (Requires more calculations and scrolling properly). Or do we want to scroll to the selected tab every time a tab is closed?
Please treat this patch to be a WIP until we know what we want to do ;)
Comment on attachment 595217 [details] [diff] [review]
Patch

Do we really need the mScrollToSelectedTab code at all? When a user closes a tab, we should not attempt to scroll at all, right?

Changing from review to feedback
Attachment #595217 - Flags: review?(mark.finkle) → feedback+
Attached patch PatchSplinter Review
This seems a better approach to me. Here we just remove the tab from the adapter and invalidate the list's views. Thereby the scroll position is retained (by listview itself), the views are redrawn as needed.
Attachment #595217 - Attachment is obsolete: true
Attachment #596841 - Flags: review?(mark.finkle)
Attachment #596841 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/1c5c5e78f370
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
Nightly 13.0a1 (2012-02-15)
Device: Samsung Nexus S - Android 2.3.6

When closing the last tab, the second to last tab is the last tab now and is selected and in view.
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.