Closed
Bug 718281
Opened 14 years ago
Closed 14 years ago
Hide Tilt outro transition in a pref
Categories
(DevTools :: Inspector, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 12
People
(Reporter: vporof, Assigned: vporof)
References
Details
(Whiteboard: [tilt][fixed-in-fx-team])
Attachments
(1 file, 2 obsolete files)
2.28 KB,
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
Transition added by bug 712096. The animation itself may be annoying in some cases so it may be a good idea to have it disabled and hidden by default under a pref.
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Whiteboard: [tilt]
Assignee | ||
Comment 1•14 years ago
|
||
Also, as long as we're adding an outro transition pref, we should also add an intro transition pref.
Assignee | ||
Comment 2•14 years ago
|
||
Attachment #588734 -
Flags: review?(rcampbell)
Comment 3•14 years ago
|
||
I think we should show the transitions by default. If the speed of them is annoying, we can make it faster or slower.
Assignee | ||
Comment 4•14 years ago
|
||
Here's a use case:
I open Tilt with an element at position (0, 0) selected. I pan down and select an element at position (0, n). Then I pan the camera back up. (I personally find myself in this case).
Suppose n > 2000 (or even a smaller number). If the closing animation is really fast, then it would be annoying (too choppy/jumpy). If it's slower, it would be counter productive.
What do you think?
Assignee | ||
Comment 5•14 years ago
|
||
Ok, talked to some people and it seems everyone wants an outro animation :)
I give in. Rob, what do you think?
Attachment #588759 -
Flags: review?(rcampbell)
Assignee | ||
Updated•14 years ago
|
Attachment #588759 -
Attachment is patch: true
Assignee | ||
Comment 6•14 years ago
|
||
Cleaned up, rebased on 712096.
Attachment #588734 -
Attachment is obsolete: true
Attachment #588759 -
Attachment is obsolete: true
Attachment #588734 -
Flags: review?(rcampbell)
Attachment #588759 -
Flags: review?(rcampbell)
Attachment #588816 -
Flags: review?(rcampbell)
Comment 7•14 years ago
|
||
yes, I think a matching, closing transition is definitely nice to have and adds to the seamlessness of the visualization. Adding a pref to hide these things is fine, as long as they are enabled by default. Will review in greater depth forthwith.
Comment 8•14 years ago
|
||
Comment on attachment 588816 [details] [diff] [review]
v3
sure thing!
Attachment #588816 -
Flags: review?(rcampbell) → review+
Comment 9•14 years ago
|
||
Whiteboard: [tilt] → [tilt][fixed-in-fx-team]
Comment 10•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Comment 11•14 years ago
|
||
Comment on attachment 588816 [details] [diff] [review]
v3
[Approval Request Comment]
Regression caused by (bug #): new feature
User impact if declined: Won't be able to turn off outro transitions with a preference.
Testing completed (on m-c, etc.): on mc.
Risk to taking this patch (and alternatives if risky): Minimal. In fact, this patch makes it possible to disable a feature we may want.
Attachment #588816 -
Flags: approval-mozilla-aurora?
Updated•14 years ago
|
tracking-firefox11:
--- → ?
Updated•14 years ago
|
Attachment #588816 -
Flags: approval-mozilla-aurora?
Updated•14 years ago
|
tracking-firefox11:
? → ---
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•