Closed Bug 718281 Opened 10 years ago Closed 10 years ago

Hide Tilt outro transition in a pref


(DevTools :: Inspector, defect)

12 Branch
Not set


(Not tracked)

Firefox 12


(Reporter: vporof, Assigned: vporof)



(Whiteboard: [tilt][fixed-in-fx-team])


(1 file, 2 obsolete files)

Transition added by bug 712096. The animation itself may be annoying in some cases so it may be a good idea to have it disabled and hidden by default under a pref.
Assignee: nobody → vporof
Whiteboard: [tilt]
Also, as long as we're adding an outro transition pref, we should also add an intro transition pref.
Attached patch v1 (obsolete) — Splinter Review
Attachment #588734 - Flags: review?(rcampbell)
I think we should show the transitions by default. If the speed of them is annoying, we can make it faster or slower.
Here's a use case:

I open Tilt with an element at position (0, 0) selected. I pan down and select an element at position (0, n). Then I pan the camera back up. (I personally find myself in this case).

Suppose n > 2000 (or even a smaller number). If the closing animation is really fast, then it would be annoying (too choppy/jumpy). If it's slower, it would be counter productive.

What do you think?
Attached patch v2 (obsolete) — Splinter Review
Ok, talked to some people and it seems everyone wants an outro animation :)
I give in. Rob, what do you think?
Attachment #588759 - Flags: review?(rcampbell)
Attachment #588759 - Attachment is patch: true
Attached patch v3Splinter Review
Cleaned up, rebased on 712096.
Attachment #588734 - Attachment is obsolete: true
Attachment #588759 - Attachment is obsolete: true
Attachment #588734 - Flags: review?(rcampbell)
Attachment #588759 - Flags: review?(rcampbell)
Attachment #588816 - Flags: review?(rcampbell)
yes, I think a matching, closing transition is definitely nice to have and adds to the seamlessness of the visualization. Adding a pref to hide these things is fine, as long as they are enabled by default. Will review in greater depth forthwith.
Comment on attachment 588816 [details] [diff] [review]

sure thing!
Attachment #588816 - Flags: review?(rcampbell) → review+
Depends on: 712096
Whiteboard: [tilt] → [tilt][fixed-in-fx-team]
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Blocks: 715647
Comment on attachment 588816 [details] [diff] [review]

[Approval Request Comment]
Regression caused by (bug #): new feature
User impact if declined: Won't be able to turn off outro transitions with a preference.
Testing completed (on m-c, etc.): on mc.
Risk to taking this patch (and alternatives if risky): Minimal. In fact, this patch makes it possible to disable a feature we may want.
Attachment #588816 - Flags: approval-mozilla-aurora?
Attachment #588816 - Flags: approval-mozilla-aurora?
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.