718295 - Don't rm files after zipping them into the omnijar

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

For some reasons I don't understand, when zipping the omnijar, we are using -m option which means the original files are actually removed when added to the zip. That is affecting the effort of fast packaging and that seems useless because we can safely assume that files will be re-generated if required, we don't have to delete them for that.

Comment 1

[Mike Hommey [:glandium]]

Comment on attachment 588741 [details] [diff] [review]
Patch v1

The files are removed from dist/$APP, not dist/bin, so it doesn't make anything uselessly regenerated. Moreover, even removing from dist/bin doesn't change much, since files are only regenerated when they are not in $objdir/$srcdir.
Removing from dist/$APP is also necessary for the files *not* to be in the final package. In the case of the omnijar, this means you end up with chrome and other stuff, on android, in both the apk and the omni.ja inside the apk. In the case of jsloader resources, it's useful so that if a js module is removed, its cache version doesn't end up in the package.