718303 - Tilt intro and outro transitions aren't very precise when page is zoomed

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Changes are backed up by existing tests. For the rest of the stuff in the patch, it's mostly about visual changes.

Comment 2

[Victor Porof [:vporof][:vp]]

Attachment: v2

Cleaned up, try is green.
https://tbpl.mozilla.org/?tree=Try&rev=99f836e9fef1

Comment 3

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 588818 [details] [diff] [review]
v2

looks good

Comment 4

[Dão Gottwald [:dao]]

The right and accurate way to get the zoom ratio is nsIDOMWindowUtils::screenPixelsPerCSSPixel.

Comment 5

[Paul Rouget [:paul]]

This highlighter as a `zoom` property that uses `nsIDOMWindowUtils::screenPixelsPerCSSPixel`.

Just use highlighter.zoom.

http://mxr.mozilla.org/mozilla-central/source/browser/devtools/highlighter/highlighter.jsm#626

Comment 6

[Victor Porof [:vporof][:vp]]

Yes, we can and should use this. Follow-up bug to avoid rebasing 7 other patches :)
Thanks Paul!

Comment 7

[Victor Porof [:vporof][:vp]]

Bug 719877.

Comment 8

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/586448c078ef

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/586448c078ef

Comment 10

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 588818 [details] [diff] [review]
v2

[Approval Request Comment]
Regression caused by (bug #): New feature
User impact if declined: Intro and outro transitions may be inaccurate on zoomed pages.
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): Low risk. Small patch.

Comment 11

[Rob Campbell [:rc] (:robcee)]

bugzilla :|