Closed Bug 718303 Opened 8 years ago Closed 8 years ago

Tilt intro and outro transitions aren't very precise when page is zoomed

Categories

(DevTools :: Inspector, defect)

12 Branch
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 12

People

(Reporter: vporof, Assigned: vporof)

References

Details

(Whiteboard: [tilt])

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Whiteboard: [tilt]
Attached patch v1 (obsolete) — Splinter Review
Changes are backed up by existing tests. For the rest of the stuff in the patch, it's mostly about visual changes.
Attachment #588757 - Flags: review?(rcampbell)
Attached patch v2Splinter Review
Cleaned up, try is green.
https://tbpl.mozilla.org/?tree=Try&rev=99f836e9fef1
Attachment #588757 - Attachment is obsolete: true
Attachment #588757 - Flags: review?(rcampbell)
Attachment #588818 - Flags: review?(rcampbell)
Comment on attachment 588818 [details] [diff] [review]
v2

looks good
Attachment #588818 - Flags: review?(rcampbell) → review+
The right and accurate way to get the zoom ratio is nsIDOMWindowUtils::screenPixelsPerCSSPixel.
This highlighter as a `zoom` property that uses `nsIDOMWindowUtils::screenPixelsPerCSSPixel`.

Just use highlighter.zoom.

http://mxr.mozilla.org/mozilla-central/source/browser/devtools/highlighter/highlighter.jsm#626
Yes, we can and should use this. Follow-up bug to avoid rebasing 7 other patches :)
Thanks Paul!
Depends on: 715647
Blocks: 718425
https://hg.mozilla.org/integration/fx-team/rev/586448c078ef
Whiteboard: [tilt] → [tilt][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/586448c078ef
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [tilt][fixed-in-fx-team] → [tilt]
Target Milestone: --- → Firefox 12
Comment on attachment 588818 [details] [diff] [review]
v2

[Approval Request Comment]
Regression caused by (bug #): New feature
User impact if declined: Intro and outro transitions may be inaccurate on zoomed pages.
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): Low risk. Small patch.
Attachment #588818 - Flags: approval-mozilla-aurora?
Target Milestone: Firefox 12 → ---
bugzilla :|
Target Milestone: --- → Firefox 12
Attachment #588818 - Flags: approval-mozilla-aurora?
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.