The default bug view has changed. See this FAQ.

Tilt intro and outro transitions aren't very precise when page is zoomed

RESOLVED FIXED in Firefox 12

Status

()

Firefox
Developer Tools: Inspector
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: vporof, Assigned: vporof)

Tracking

12 Branch
Firefox 12
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [tilt])

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Updated

5 years ago
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Whiteboard: [tilt]
(Assignee)

Comment 1

5 years ago
Created attachment 588757 [details] [diff] [review]
v1

Changes are backed up by existing tests. For the rest of the stuff in the patch, it's mostly about visual changes.
Attachment #588757 - Flags: review?(rcampbell)
(Assignee)

Comment 2

5 years ago
Created attachment 588818 [details] [diff] [review]
v2

Cleaned up, try is green.
https://tbpl.mozilla.org/?tree=Try&rev=99f836e9fef1
Attachment #588757 - Attachment is obsolete: true
Attachment #588757 - Flags: review?(rcampbell)
Attachment #588818 - Flags: review?(rcampbell)
Comment on attachment 588818 [details] [diff] [review]
v2

looks good
Attachment #588818 - Flags: review?(rcampbell) → review+
The right and accurate way to get the zoom ratio is nsIDOMWindowUtils::screenPixelsPerCSSPixel.

Comment 5

5 years ago
This highlighter as a `zoom` property that uses `nsIDOMWindowUtils::screenPixelsPerCSSPixel`.

Just use highlighter.zoom.

http://mxr.mozilla.org/mozilla-central/source/browser/devtools/highlighter/highlighter.jsm#626
(Assignee)

Comment 6

5 years ago
Yes, we can and should use this. Follow-up bug to avoid rebasing 7 other patches :)
Thanks Paul!
(Assignee)

Comment 7

5 years ago
Bug 719877.
Depends on: 715647
(Assignee)

Updated

5 years ago
Blocks: 718425
https://hg.mozilla.org/integration/fx-team/rev/586448c078ef
Whiteboard: [tilt] → [tilt][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/586448c078ef
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [tilt][fixed-in-fx-team] → [tilt]
Target Milestone: --- → Firefox 12
Comment on attachment 588818 [details] [diff] [review]
v2

[Approval Request Comment]
Regression caused by (bug #): New feature
User impact if declined: Intro and outro transitions may be inaccurate on zoomed pages.
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): Low risk. Small patch.
Attachment #588818 - Flags: approval-mozilla-aurora?
tracking-firefox11: --- → ?
Target Milestone: Firefox 12 → ---
bugzilla :|
Target Milestone: --- → Firefox 12
tracking-firefox11: ? → ---
Attachment #588818 - Flags: approval-mozilla-aurora?
You need to log in before you can comment on or make changes to this bug.