718359 - configure.in: remove useless SANITY_CHECKING_FEATURE and XCB_SURFACE_FEATURE

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Serge Gautherie (:sgautherie)]

(Follow-up to bug 513702.)

Afaict, these 2 variables are (now?) unused.

http://mxr.mozilla.org/mozilla-central/search?string=SANITY_CHECKING_FEATURE&case=1&find=%2Fconfigure.in%24
{
/configure.in
    * line 8115 -- SANITY_CHECKING_FEATURE="#define CAIRO_DO_SANITY_CHECKING 1"
    * line 8117 -- SANITY_CHECKING_FEATURE="#undef CAIRO_DO_SANITY_CHECKING"
}
http://mxr.mozilla.org/mozilla-central/search?string=CAIRO_DO_SANITY_CHECKING&case=1&find=%2Fconfigure.in%24
Same result.

http://mxr.mozilla.org/mozilla-central/search?string=XCB_SURFACE_FEATURE&case=1&find=\.in%24
{
/configure.in
    * line 8127 -- AC_SUBST(XCB_SURFACE_FEATURE)
/gfx/cairo/cairo/src/cairo-features.h.in
    * line 72 -- @XCB_SURFACE_FEATURE@
}

Comment 1

[Mark Capella [:capella]]

Attachment: Remove obsolete variables

Comment 2

[Mark Capella [:capella]]

   Coded, tested / re-built with mozilla-central pull -u ... all seems to work.

Comment 3

[Mark Capella [:capella]]

   Ping jmuizelaar for the review? ...

Comment 4

[Mark Capella [:capella]]

Serge: we're still waiting on the review ... is there a follow-up plan to move this forward?

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to Mark Capella [:capella] from comment #4)
> Serge: we're still waiting on the review ... is there a follow-up plan to
> move this forward?

I can't do more than f+.
I guessed a reviewer by default: if that doesn't work, you may try differently.
But I already spend too much time trying to get reviews for my own patches :-/

Comment 6

[Mozilla RelEng Bot]

Autoland Patchset:
	Patches: 596671
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=eac9ccf85315
Try run started, revision eac9ccf85315. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=eac9ccf85315

Comment 7

[Mozilla RelEng Bot]

Try run for eac9ccf85315 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=eac9ccf85315
Results (out of 218 total builds):
    success: 180
    warnings: 24
    failure: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-eac9ccf85315

Comment 8

[Serge Gautherie (:sgautherie)]

(In reply to Mozilla RelEng Bot from comment #7)
>     failure: 14

You should mark (and comment about) the failures before asking for c-n:

Some are from ignored builds and you shouldn't care about them.
https://tbpl.mozilla.org/?tree=Try&rev=eac9ccf85315&noignore=1

The unignored ones, you should check whether they are (known) random, or (filed) regression.
Running failed builds another time may help, if in doubt.

Comment 9

[Mozilla RelEng Bot]

Autoland Patchset:
	Patches: 596671
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=0054ee0029bb
Try run started, revision 0054ee0029bb. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=0054ee0029bb

Comment 10

[Jonathan Kew [:jfkthame]]

(In reply to Serge Gautherie (:sgautherie) from comment #8)
> (In reply to Mozilla RelEng Bot from comment #7)
> >     failure: 14
> 
> You should mark (and comment about) the failures before asking for c-n:
> 
> Some are from ignored builds and you shouldn't care about them.
> https://tbpl.mozilla.org/?tree=Try&rev=eac9ccf85315&noignore=1
> 
> The unignored ones, you should check whether they are (known) random, or
> (filed) regression.
> Running failed builds another time may help, if in doubt.

That actually looks like a pretty clean tryserver run; I don't see any reason this shouldn't land.

Comment 11

[Mark Capella [:capella]]

Not sure why extra message show up with ignore=1 option, all seem to involve jetpack ... results from   https://tbpl.mozilla.org/?tree=Try&rev=eac9ccf85315 only show a few warnings that didnt seem to involve my changes.

I posted another TRY in either case.

Comment 12

[Mozilla RelEng Bot]

Try run for 0054ee0029bb is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=0054ee0029bb
Results (out of 220 total builds):
    exception: 6
    success: 175
    warnings: 25
    failure: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-0054ee0029bb

Comment 13

[Mark Capella [:capella]]

With comment #10 and re-review of warnings in https://tbpl.mozilla.org/?tree=Try&rev=0054ee0029bb I'm again asking for check-in.

Comment 14

[Serge Gautherie (:sgautherie)]

(In reply to Mark Capella [:capella] from comment #11)

> Not sure why extra message show up with ignore=1 option

These builds are "hidden" by default, until they are fixed.

Comment 15

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5dd8529c9346

Comment 16

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/5dd8529c9346

Comment 17

[Serge Gautherie (:sgautherie)]

V.Fixed, per MXR.