718392 - [Mac] Restore non-highlight when hovering menus in content menubars

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Stefan [:stefanh]]

The patch in bug 595201 made XUL menus in content menubars highlight when you hover them. This is not the default behavior on Mac (and the bg-color is wrong).

Comment 1

[Stefan [:stefanh]]

(never mind what I said about the bg-color, there shouldn't be any)

Comment 2

[Stefan [:stefanh]]

Attachment: Restore old behavior

What they did in bug 632989, should work here too. But I don't think we want that (it would for example affect menus in editable menulists)

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 588838 [details] [diff] [review]
Restore old behavior

>+  background-color: inherit;

Why inherit? I think you want transparent here.

Comment 4

[Stefan [:stefanh]]

(In reply to Dão Gottwald [:dao] from comment #3)
> Comment on attachment 588838 [details] [diff] [review]
> Restore old behavior
> 
> >+  background-color: inherit;
> 
> Why inherit? I think you want transparent here.

Ah, yes, true (inherit works because the menubar has a transparent bg, but you're right).

Comment 5

[Stefan [:stefanh]]

Attachment: Now with transparent background

Comment 6

[Stefan [:stefanh]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/098a5b456aef

Comment 7

[Stefan [:stefanh]]

Whoops...

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/098a5b456aef