71845 - Schedule/Notify tabs in bookmark properties don't show if url starts with HTTP (upper case)

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Nahor]

If a bookmark location has the protocol written in upper case ("HTTP" instead of
"http") the Schedule and Notify tabs don't show up in the properties dialog box.

Comment 1

[timeless]

Attachment: fix

Comment 2

[timeless]

mao: this is your code, please r= or suggest an alternative. alecf or ben 
please a= if mao doesn't object to the style of my fix.

Comment 3

[Mark Olson]

Attachment: patch - another alternative

Comment 4

[Mark Olson]

I don't mind which way we do it, but if we go with timeless' patch, I'd rather
see something like:
   var temp = gBookmarkURL.toLowerCase(); 
   if (temp.indexOf("http://") != 0 &&
       temp.indexOf("https://") != 0) {

I'd say let Ben decide and timeless or i can r= the chosen code.

Comment 5

[Mark Olson]

Incidentally, the reason not to use timeless' original patch is that case
sensitive bookmarks would be ruined by it.  So either the temp variable or my
patch would be the way to go.

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

a=ben

Comment 7

[Peter "jag" Annema]

r=jag on either of mao's suggested fixed.

mao, you pick a version :-)

Comment 8

[Mark Olson]

fix checked in.  went with the latest attached patch, not the inline version.

Comment 9

[Nahor]

Cleaning my old bugs