The default bug view has changed. See this FAQ.

Building layout/media doesn't link gkmedias.dll on Windows

RESOLVED FIXED in mozilla12

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: cpearce, Assigned: glandium)

Tracking

Trunk
mozilla12
All
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
STR:

ls -l objdir/dist/bin/gkmedias.dll
touch media/libsydneyaudio/src/sydneyaudio_waveapi.c
make -C objdir/media/libsydneyaudio
make -C objdir/layout/media
ls -l objdir/dist/bin/gkmedias.dll

Observe timestamp not updated, gkmedias.dll hasn't been relinked.

Mike has a patch that fixes this.
(Assignee)

Comment 1

5 years ago
Created attachment 589010 [details] [diff] [review]
Make the gkmedia library the default target in layout/media
Attachment #589010 - Flags: review?(khuey)
(Assignee)

Updated

5 years ago
Component: Video/Audio → Build Config
QA Contact: video.audio → build-config
Hardware: x86_64 → All
(Assignee)

Updated

5 years ago
Blocks: 709721
(Reporter)

Comment 2

5 years ago
Unfortunately that patch fails on a to build on Try:
https://tbpl.mozilla.org/?tree=Try&rev=1a5da15d8a7d

:(
(Assignee)

Comment 3

5 years ago
Created attachment 589109 [details] [diff] [review]
Make the gkmedia library the default target in layout/media

DEFFILE needs to be defined before including rules.mk
Attachment #589109 - Flags: review?(khuey)
(Assignee)

Updated

5 years ago
Attachment #589010 - Attachment is obsolete: true
Attachment #589010 - Flags: review?(khuey)
Attachment #589109 - Flags: review?(khuey) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/0fce8e34930f
(forgot the r=khuey in the commit message :( )
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/0fce8e34930f
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.