Closed
Bug 718485
Opened 14 years ago
Closed 14 years ago
Building layout/media doesn't link gkmedias.dll on Windows
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla12
People
(Reporter: cpearce, Assigned: glandium)
References
Details
(Whiteboard: [inbound])
Attachments
(1 file, 1 obsolete file)
|
1.13 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
STR:
ls -l objdir/dist/bin/gkmedias.dll
touch media/libsydneyaudio/src/sydneyaudio_waveapi.c
make -C objdir/media/libsydneyaudio
make -C objdir/layout/media
ls -l objdir/dist/bin/gkmedias.dll
Observe timestamp not updated, gkmedias.dll hasn't been relinked.
Mike has a patch that fixes this.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #589010 -
Flags: review?(khuey)
|
|
Assignee | |
Updated•14 years ago
|
Component: Video/Audio → Build Config
QA Contact: video.audio → build-config
Hardware: x86_64 → All
|
Reporter | |
Comment 2•14 years ago
|
||
Unfortunately that patch fails on a to build on Try:
https://tbpl.mozilla.org/?tree=Try&rev=1a5da15d8a7d
:(
|
|
Assignee | |
Comment 3•14 years ago
|
||
DEFFILE needs to be defined before including rules.mk
Attachment #589109 -
Flags: review?(khuey)
|
|
Assignee | |
Updated•14 years ago
|
Attachment #589010 -
Attachment is obsolete: true
Attachment #589010 -
Flags: review?(khuey)
Attachment #589109 -
Flags: review?(khuey) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0fce8e34930f
(forgot the r=khuey in the commit message :( )
Whiteboard: [inbound]
|
||
Comment 5•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
|
||
Updated•8 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•