Last Comment Bug 718485 - Building layout/media doesn't link gkmedias.dll on Windows
: Building layout/media doesn't link gkmedias.dll on Windows
Status: RESOLVED FIXED
[inbound]
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All Windows 7
: -- normal (vote)
: mozilla12
Assigned To: Mike Hommey [:glandium]
:
:
Mentors:
Depends on:
Blocks: 709721
  Show dependency treegraph
 
Reported: 2012-01-16 11:43 PST by Chris Pearce (:cpearce)
Modified: 2012-01-21 07:07 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Make the gkmedia library the default target in layout/media (1.12 KB, patch)
2012-01-16 14:21 PST, Mike Hommey [:glandium]
no flags Details | Diff | Splinter Review
Make the gkmedia library the default target in layout/media (1.13 KB, patch)
2012-01-16 22:47 PST, Mike Hommey [:glandium]
khuey: review+
Details | Diff | Splinter Review

Description Chris Pearce (:cpearce) 2012-01-16 11:43:40 PST
STR:

ls -l objdir/dist/bin/gkmedias.dll
touch media/libsydneyaudio/src/sydneyaudio_waveapi.c
make -C objdir/media/libsydneyaudio
make -C objdir/layout/media
ls -l objdir/dist/bin/gkmedias.dll

Observe timestamp not updated, gkmedias.dll hasn't been relinked.

Mike has a patch that fixes this.
Comment 1 Mike Hommey [:glandium] 2012-01-16 14:21:10 PST
Created attachment 589010 [details] [diff] [review]
Make the gkmedia library the default target in layout/media
Comment 2 Chris Pearce (:cpearce) 2012-01-16 19:48:05 PST
Unfortunately that patch fails on a to build on Try:
https://tbpl.mozilla.org/?tree=Try&rev=1a5da15d8a7d

:(
Comment 3 Mike Hommey [:glandium] 2012-01-16 22:47:35 PST
Created attachment 589109 [details] [diff] [review]
Make the gkmedia library the default target in layout/media

DEFFILE needs to be defined before including rules.mk
Comment 4 Mike Hommey [:glandium] 2012-01-20 00:54:07 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/0fce8e34930f
(forgot the r=khuey in the commit message :( )
Comment 5 Ed Morley [:emorley] 2012-01-21 07:07:16 PST
https://hg.mozilla.org/mozilla-central/rev/0fce8e34930f

Note You need to log in before you can comment on or make changes to this bug.