718499 - Save as PDF saves content from the wrong tab

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: logcat

Fennec Native nightly 2012-01-16, Android 4.0.3 stock, Google Nexus S

The 'Save as PDF' function from the menu does not work if only one tab has is open, no notification will be shown, a file with the file size 0 byte will be created.

Steps to reproduce:
1. Open http://tagesschau.de
2. Wait for the page finishing to load.
3. Open the menu and choose 'Save as PDF'.

Open a second tab and try again (independent if first/old or second tab used), it will work.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

I am wrong, saving the first tab as PDF saves the second tab with the file name from the first page's title.

Comment 2

[Aaron Train [:aaronmt]]

Looks like a regression.

I noticed in console after tapping "Save as PDF" -> E/GeckoConsole( 3863): [JavaScript Error: "this.browser is null" {file: "chrome://browser/content/browser.js" line: 1983}]

Comment 3

[Madhava Enros [:madhava]]

I find that it always saves the last tab, no matter what tab you're on when you initiate "Save as PDF." I would expect it to save the _current_ tab.

Comment 4

[:Margaret Leibovic]

Attachment: patch

I couldn't reproduce the error Aaron was seeing, but this fixes the issue Madhava was talking about - we were getting the content from the wrong browser.

It looks like the root problem causing this issue is that we're dynamically setting browser type to content-primary [1], but you can't actually set that property after the browser has been inserted into the DOM [2]. I don't know what we should do to fix this, but we should be careful about other problems that might pop up because of this.

[1] http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#1425
[2] https://developer.mozilla.org/en/XUL/Attribute/browser.type

Comment 5

[:Margaret Leibovic]

(In reply to Archaeopteryx [:aryx] from comment #0)
 
> The 'Save as PDF' function from the menu does not work if only one tab has
> is open, no notification will be shown, a file with the file size 0 byte
> will be created.

Archaeopteryx, do you still see this? We kinda hijacked this bug to fix your issue from comment 1, so I'm updating the bug summary, but I want to fix this original issue if it still exists.

Comment 6

[:Margaret Leibovic]

I don't think this is a regression - just something we never noticed.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 589605 [details] [diff] [review]
patch

O_o

Can't believe we missed that :)

Comment 8

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1d3e470a4709

Comment 9

[Marco Bonardo [:mak] (away 22-26 Sept)]

https://hg.mozilla.org/mozilla-central/rev/1d3e470a4709

Comment 10

[:Margaret Leibovic]

Comment on attachment 589605 [details] [diff] [review]
patch

[Approval Request Comment]
Mobile-only. Save as PDF is busted without it.

Comment 11

[Alex Keybl [:akeybl]]

Comment on attachment 589605 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.

Comment 12

[:Margaret Leibovic]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d75216b1edc7

Comment 13

[Aaron Train [:aaronmt]]

Verified on M-A & M-C
Galaxy Nexus (Android 4.0.3)

20120126053754
http://hg.mozilla.org/releases/mozilla-aurora/rev/9d5ede8cb11a

20120126031113
http://hg.mozilla.org/mozilla-central/rev/402b394b6623