IonMonkey: LSRA: don't search for blocking intervals if the register was free

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
assign() searches active/inactive for blocking intervals, even if findBestFreeRegister found a free register. Simplest fix is to either move the splitting code to a separate function (splitBlockingIntervals or something) or to give assign an optional isFree argument.
(Assignee)

Comment 1

5 years ago
Created attachment 589022 [details] [diff] [review]
Patch

Move the splitting code from assign to splitBlockingIntervals, and call it when assigning a blocked register.

Applies on top of the patches in bug 712278.
Attachment #589022 - Flags: review?(dvander)
Attachment #589022 - Flags: review?(dvander) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/projects/ionmonkey/rev/7685f6b2f00d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.