Last Comment Bug 718505 - IonMonkey: LSRA: don't search for blocking intervals if the register was free
: IonMonkey: LSRA: don't search for blocking intervals if the register was free
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Jan de Mooij [:jandem]
:
:
Mentors:
Depends on:
Blocks: 670624
  Show dependency treegraph
 
Reported: 2012-01-16 13:07 PST by Jan de Mooij [:jandem]
Modified: 2012-01-20 13:25 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (8.96 KB, patch)
2012-01-16 14:34 PST, Jan de Mooij [:jandem]
dvander: review+
Details | Diff | Splinter Review

Description Jan de Mooij [:jandem] 2012-01-16 13:07:10 PST
assign() searches active/inactive for blocking intervals, even if findBestFreeRegister found a free register. Simplest fix is to either move the splitting code to a separate function (splitBlockingIntervals or something) or to give assign an optional isFree argument.
Comment 1 Jan de Mooij [:jandem] 2012-01-16 14:34:55 PST
Created attachment 589022 [details] [diff] [review]
Patch

Move the splitting code from assign to splitBlockingIntervals, and call it when assigning a blocked register.

Applies on top of the patches in bug 712278.
Comment 2 Jan de Mooij [:jandem] 2012-01-20 13:25:19 PST
https://hg.mozilla.org/projects/ionmonkey/rev/7685f6b2f00d

Note You need to log in before you can comment on or make changes to this bug.