Last Comment Bug 718634 - Move CanSkip* to nsCycleCollectionParticipant
: Move CanSkip* to nsCycleCollectionParticipant
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: 12 Branch
: All All
: -- normal (vote)
: ---
Assigned To: Olli Pettay [:smaug] (high review load, please consider other reviewers)
:
Mentors:
Depends on:
Blocks: 705371 712170
  Show dependency treegraph
 
Reported: 2012-01-17 06:32 PST by Olli Pettay [:smaug] (high review load, please consider other reviewers)
Modified: 2012-01-17 09:51 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (4.91 KB, patch)
2012-01-17 06:32 PST, Olli Pettay [:smaug] (high review load, please consider other reviewers)
continuation: review+
Details | Diff | Review

Description Olli Pettay [:smaug] (high review load, please consider other reviewers) 2012-01-17 06:32:59 PST
Created attachment 589176 [details] [diff] [review]
patch

hg diff created a bit strange output. I moved CanSkip* methods, not the other methods.
And I changed the ctors.

The patch adds CanSkipThis only to NoteRoot, but it could be added perhaps
also elsewhere. But that can be done when needed.

This patch was required to skip nsJSEventListeners
Comment 1 Andrew McCreight (PTO-ish through 6-29) [:mccr8] 2012-01-17 06:54:04 PST
Comment on attachment 589176 [details] [diff] [review]
patch

Looks good.

Yeah, HG's default diff does not handle moving chunks of code around very well.  There's some way to set it so you can manually use a different diff that will produce better results in these situations, but I don't remember how to do that off hand.
Comment 2 Olli Pettay [:smaug] (high review load, please consider other reviewers) 2012-01-17 09:51:37 PST
https://hg.mozilla.org/mozilla-central/rev/1cfc17f1bd13

Note You need to log in before you can comment on or make changes to this bug.