Move CanSkip* to nsCycleCollectionParticipant

RESOLVED FIXED

Status

()

Core
XPCOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

12 Branch
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 589176 [details] [diff] [review]
patch

hg diff created a bit strange output. I moved CanSkip* methods, not the other methods.
And I changed the ctors.

The patch adds CanSkipThis only to NoteRoot, but it could be added perhaps
also elsewhere. But that can be done when needed.

This patch was required to skip nsJSEventListeners
Attachment #589176 - Flags: review?(continuation)
Comment on attachment 589176 [details] [diff] [review]
patch

Looks good.

Yeah, HG's default diff does not handle moving chunks of code around very well.  There's some way to set it so you can manually use a different diff that will produce better results in these situations, but I don't remember how to do that off hand.
Attachment #589176 - Flags: review?(continuation) → review+
Blocks: 705371
Blocks: 712170
OS: Linux → All
Hardware: x86_64 → All
(Assignee)

Comment 2

6 years ago
https://hg.mozilla.org/mozilla-central/rev/1cfc17f1bd13
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.