Last Comment Bug 718634 - Move CanSkip* to nsCycleCollectionParticipant
: Move CanSkip* to nsCycleCollectionParticipant
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: 12 Branch
: All All
-- normal (vote)
: ---
Assigned To: Olli Pettay [:smaug]
: Nathan Froyd [:froydnj]
Depends on:
Blocks: 705371 712170
  Show dependency treegraph
Reported: 2012-01-17 06:32 PST by Olli Pettay [:smaug]
Modified: 2012-01-17 09:51 PST (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (4.91 KB, patch)
2012-01-17 06:32 PST, Olli Pettay [:smaug]
continuation: review+
Details | Diff | Splinter Review

Description User image Olli Pettay [:smaug] 2012-01-17 06:32:59 PST
Created attachment 589176 [details] [diff] [review]

hg diff created a bit strange output. I moved CanSkip* methods, not the other methods.
And I changed the ctors.

The patch adds CanSkipThis only to NoteRoot, but it could be added perhaps
also elsewhere. But that can be done when needed.

This patch was required to skip nsJSEventListeners
Comment 1 User image Andrew McCreight [:mccr8] 2012-01-17 06:54:04 PST
Comment on attachment 589176 [details] [diff] [review]

Looks good.

Yeah, HG's default diff does not handle moving chunks of code around very well.  There's some way to set it so you can manually use a different diff that will produce better results in these situations, but I don't remember how to do that off hand.
Comment 2 User image Olli Pettay [:smaug] 2012-01-17 09:51:37 PST

Note You need to log in before you can comment on or make changes to this bug.