Closed Bug 718737 Opened 13 years ago Closed 13 years ago

Add a startup timeline event on nsDocShell::LoadURI

Categories

(Core :: DOM: Navigation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

We want to report, like we currently do for timestamps like main, sessionRestore, firstPaint, etc., the timestamp at which the first non about:blank uri is loaded.
Assignee: nobody → mh+mozilla
Blocks: 718738
Comment on attachment 589432 [details] [diff] [review] Add a startup timeline event on the first nsDocShell::LoadURI for non about:blank content Asking taras review for StartupTimeline changes (it appears gcc is stupid and doesn't realize it doesn't need to call PR_Now when the condition is not fulfilled).
Attachment #589432 - Flags: review?(taras.mozilla)
Summary: Add a timestamp probe on nsDocShell::LoadURI → Add a startup timeline event on nsDocShell::LoadURI
There's a glitch, though: we're going to have noise in our telemetry data on android, because fennec doesn't load any non about:blank content when starting without an url (that is, when showing the non-content/native-android-ui about:home).
Interestingly, the startup timeline event is triggered at what seems a "normal" time when starting fennec without an url, so forget comment 3.
Comment on attachment 589432 [details] [diff] [review] Add a startup timeline event on the first nsDocShell::LoadURI for non about:blank content I think this should work
Attachment #589432 - Flags: review?(taras.mozilla) → review+
Comment on attachment 589432 [details] [diff] [review] Add a startup timeline event on the first nsDocShell::LoadURI for non about:blank content "mItemType == typeContent" has extra parens around it, and you're reinventing NS_IsAboutBlank. r=me with those bits fixed.
Attachment #589432 - Flags: review?(bzbarsky) → review+
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Will this cause slightly bogus values for people who have about:blank as their homepage? It's going to be a small number of people, but I'm sure they exist (there used to be a button in preferences for it a few years ago).
Probably. I'm one of those people, certainly. And there's still a preference for it.
Most definitely yes.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: