718737 - Add a startup timeline event on nsDocShell::LoadURI

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Mike Hommey [:glandium]]

We want to report, like we currently do for timestamps like main, sessionRestore, firstPaint, etc., the timestamp at which the first non about:blank uri is loaded.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Add a startup timeline event on the first nsDocShell::LoadURI for non about:blank content

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 589432 [details] [diff] [review]
Add a startup timeline event on the first nsDocShell::LoadURI for non about:blank content

Asking taras review for StartupTimeline changes (it appears gcc is stupid and doesn't realize it doesn't need to call PR_Now when the condition is not fulfilled).

Comment 3

[Mike Hommey [:glandium]]

There's a glitch, though: we're going to have noise in our telemetry data on android, because fennec doesn't load any non about:blank content when starting without an url (that is, when showing the non-content/native-android-ui about:home).

Comment 4

[Mike Hommey [:glandium]]

Interestingly, the startup timeline event is triggered at what seems a "normal" time when starting fennec without an url, so forget comment 3.

Comment 5

[(dormant account)]

Comment on attachment 589432 [details] [diff] [review]
Add a startup timeline event on the first nsDocShell::LoadURI for non about:blank content

I think this should work

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 589432 [details] [diff] [review]
Add a startup timeline event on the first nsDocShell::LoadURI for non about:blank content

"mItemType == typeContent" has extra parens around it, and you're reinventing NS_IsAboutBlank.

r=me with those bits fixed.

Comment 7

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ee34d8fb535d

Comment 8

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/ee34d8fb535d

Comment 9

[Daniel C]

Will this cause slightly bogus values for people who have about:blank as their homepage? It's going to be a small number of people, but I'm sure they exist (there used to be a button in preferences for it a few years ago).

Comment 10

[Boris Zbarsky [:bzbarsky]]

Probably.  I'm one of those people, certainly.  And there's still a preference for it.

Comment 11

[Mike Hommey [:glandium]]

Most definitely yes.