Add a startup timeline event on nsDocShell::LoadURI

RESOLVED FIXED

Status

()

Core
Document Navigation
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We want to report, like we currently do for timestamps like main, sessionRestore, firstPaint, etc., the timestamp at which the first non about:blank uri is loaded.
Assignee: nobody → mh+mozilla
Blocks: 718738
Created attachment 589432 [details] [diff] [review]
Add a startup timeline event on the first nsDocShell::LoadURI for non about:blank content
Attachment #589432 - Flags: review?(bzbarsky)
Comment on attachment 589432 [details] [diff] [review]
Add a startup timeline event on the first nsDocShell::LoadURI for non about:blank content

Asking taras review for StartupTimeline changes (it appears gcc is stupid and doesn't realize it doesn't need to call PR_Now when the condition is not fulfilled).
Attachment #589432 - Flags: review?(taras.mozilla)
Summary: Add a timestamp probe on nsDocShell::LoadURI → Add a startup timeline event on nsDocShell::LoadURI
There's a glitch, though: we're going to have noise in our telemetry data on android, because fennec doesn't load any non about:blank content when starting without an url (that is, when showing the non-content/native-android-ui about:home).
Interestingly, the startup timeline event is triggered at what seems a "normal" time when starting fennec without an url, so forget comment 3.

Comment 5

5 years ago
Comment on attachment 589432 [details] [diff] [review]
Add a startup timeline event on the first nsDocShell::LoadURI for non about:blank content

I think this should work
Attachment #589432 - Flags: review?(taras.mozilla) → review+
Comment on attachment 589432 [details] [diff] [review]
Add a startup timeline event on the first nsDocShell::LoadURI for non about:blank content

"mItemType == typeContent" has extra parens around it, and you're reinventing NS_IsAboutBlank.

r=me with those bits fixed.
Attachment #589432 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee34d8fb535d
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/ee34d8fb535d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]

Comment 9

5 years ago
Will this cause slightly bogus values for people who have about:blank as their homepage? It's going to be a small number of people, but I'm sure they exist (there used to be a button in preferences for it a few years ago).
Probably.  I'm one of those people, certainly.  And there's still a preference for it.
Most definitely yes.
You need to log in before you can comment on or make changes to this bug.