Closed Bug 718786 Opened 8 years ago Closed 8 years ago
Script shell exits with a zero status when program is terminated
OS: Linux → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla13
In js/src/jit-test/jit_test.py, add an 'exitstatus' jit-test cookie attribute (and rename test.error to test.expect_error). Mark tests that terminate with their expected termination code. Clean up TMFLAGS comments.
Attachment #591676 - Flags: review?(jorendorff)
Comment on attachment 591676 [details] [diff] [review] Make the shell exit with EXITCODE_RUNTIME_ERROR when code is terminated. Thanks! I'd even be OK with a bigger change in behavior here, where a single failing -e or -f causes Process to return false, and its caller checks the return value and bails out. Separate bug if so.
Attachment #591676 - Flags: review?(jorendorff) → review+
(In reply to Jason Orendorff [:jorendorff] from comment #2) > I'd even be OK with a bigger change in behavior here, where a single failing > -e or -f causes Process to return false, and its caller checks the return > value and bails out. Separate bug if so. Actually, every caller of Process already checks gExitCode, so that is the behavior this patch brings about.
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: mozilla13 → mozilla12
You need to log in before you can comment on or make changes to this bug.