Last Comment Bug 718982 - IonMonkey: Add a generic SETELEM instruction
: IonMonkey: Add a generic SETELEM instruction
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Jan de Mooij [:jandem] (PTO until July 31)
:
Mentors:
Depends on: 718683
Blocks: 684381 706328
  Show dependency treegraph
 
Reported: 2012-01-18 04:50 PST by Jan de Mooij [:jandem] (PTO until July 31)
Modified: 2012-01-26 15:46 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
WIP (18.39 KB, patch)
2012-01-18 07:12 PST, Jan de Mooij [:jandem] (PTO until July 31)
no flags Details | Diff | Splinter Review
Patch (12.25 KB, patch)
2012-01-25 12:46 PST, Jan de Mooij [:jandem] (PTO until July 31)
dvander: review+
Details | Diff | Splinter Review

Description Jan de Mooij [:jandem] (PTO until July 31) 2012-01-18 04:50:59 PST
Like bug 718683, but for SETELEM.
Comment 1 Jan de Mooij [:jandem] (PTO until July 31) 2012-01-18 07:12:48 PST
Created attachment 589496 [details] [diff] [review]
WIP

Passes tests.
Comment 2 David Anderson [:dvander] 2012-01-24 18:43:41 PST
If this is ready to review, I think this + JSOP_THROW will make kraken-audio-* compile.
Comment 3 Jan de Mooij [:jandem] (PTO until July 31) 2012-01-24 21:47:30 PST
(In reply to David Anderson [:dvander] from comment #2)
> If this is ready to review, I think this + JSOP_THROW will make
> kraken-audio-* compile.

Nice. This bug is blocked on the SETELEM interpreter stub I added in bug 718683. When the inbound patch there merges from inbound -> m-c -> Ion (hopefully today) I can fix this bug + bug 718683.

With these bugs we should also be able to run Kraken imaging-gaussian-blur.
Comment 4 Jan de Mooij [:jandem] (PTO until July 31) 2012-01-25 12:46:31 PST
Created attachment 591582 [details] [diff] [review]
Patch
Comment 5 Jan de Mooij [:jandem] (PTO until July 31) 2012-01-26 15:46:45 PST
http://hg.mozilla.org/projects/ionmonkey/rev/6f646dbc492e

Note You need to log in before you can comment on or make changes to this bug.