IonMonkey: Add a generic SETELEM instruction

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Like bug 718683, but for SETELEM.
(Assignee)

Comment 1

5 years ago
Created attachment 589496 [details] [diff] [review]
WIP

Passes tests.
If this is ready to review, I think this + JSOP_THROW will make kraken-audio-* compile.
(Assignee)

Comment 3

5 years ago
(In reply to David Anderson [:dvander] from comment #2)
> If this is ready to review, I think this + JSOP_THROW will make
> kraken-audio-* compile.

Nice. This bug is blocked on the SETELEM interpreter stub I added in bug 718683. When the inbound patch there merges from inbound -> m-c -> Ion (hopefully today) I can fix this bug + bug 718683.

With these bugs we should also be able to run Kraken imaging-gaussian-blur.
Depends on: 718683
(Assignee)

Updated

5 years ago
Blocks: 706328
(Assignee)

Comment 4

5 years ago
Created attachment 591582 [details] [diff] [review]
Patch
Attachment #589496 - Attachment is obsolete: true
Attachment #591582 - Flags: review?(dvander)
Attachment #591582 - Flags: review?(dvander) → review+
(Assignee)

Comment 5

5 years ago
http://hg.mozilla.org/projects/ionmonkey/rev/6f646dbc492e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.