Closed Bug 718982 Opened 12 years ago Closed 12 years ago

IonMonkey: Add a generic SETELEM instruction

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Like bug 718683, but for SETELEM.
Attached patch WIP (obsolete) — Splinter Review
Passes tests.
If this is ready to review, I think this + JSOP_THROW will make kraken-audio-* compile.
(In reply to David Anderson [:dvander] from comment #2)
> If this is ready to review, I think this + JSOP_THROW will make
> kraken-audio-* compile.

Nice. This bug is blocked on the SETELEM interpreter stub I added in bug 718683. When the inbound patch there merges from inbound -> m-c -> Ion (hopefully today) I can fix this bug + bug 718683.

With these bugs we should also be able to run Kraken imaging-gaussian-blur.
Depends on: 718683
Blocks: 706328
Attached patch PatchSplinter Review
Attachment #589496 - Attachment is obsolete: true
Attachment #591582 - Flags: review?(dvander)
Attachment #591582 - Flags: review?(dvander) → review+
http://hg.mozilla.org/projects/ionmonkey/rev/6f646dbc492e
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.