Atk-based plugins to slot into our a11y tree stucks orca in some flash web pages.

RESOLVED FIXED in mozilla12

Status

()

Core
Disability Access APIs
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jhk, Assigned: tbsaunde)

Tracking

({access})

unspecified
mozilla12
All
Linux
access
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

6 years ago
By Looking at Bug 665820 comment 3. It observed that implementation of atk-based plugins in Bug 480317 leads orca to stuck in some of the flash based web pages.
(Reporter)

Updated

6 years ago
Summary: Block for atk-based plugins to slot into our a11y tree. → Atk-based plugins to slot into our a11y tree stucks orca in some flash web pages.
(Reporter)

Comment 1

6 years ago
Created attachment 589478 [details] [diff] [review]
Patch
Attachment #589478 - Flags: feedback?(trev.saunders)

Comment 2

6 years ago
I've no access to Bug 665820, but it looks like you're simply backout Bug 480317.
(Reporter)

Comment 3

6 years ago
(In reply to Ginn Chen from comment #2)
> I've no access to Bug 665820, but it looks like you're simply backout Bug
> 480317.

Sorry! here is the link. https://bugzilla.gnome.org/show_bug.cgi?id=665820. 
Yes this is not final patch. It may require some debugging.

Comment 4

6 years ago
please cc us to bug 665820, I don't have an access too.

Comment 5

6 years ago
(In reply to alexander :surkov from comment #4)
> please cc us to bug 665820, I don't have an access too.

I missed that was supposed to be gnome bug, ignore my last comment.

Comment 6

6 years ago
(In reply to Ginn Chen from comment #2)
> but it looks like you're simply backout Bug
> 480317.

yep, that's what Trevor asked for in https://bugzilla.gnome.org/show_bug.cgi?id=665820 and it shouldn't be considered as proposed patch.
(Assignee)

Comment 7

6 years ago
(In reply to alexander :surkov from comment #6)
> (In reply to Ginn Chen from comment #2)
> > but it looks like you're simply backout Bug
> > 480317.
> 
> yep, that's what Trevor asked for in
> https://bugzilla.gnome.org/show_bug.cgi?id=665820 and it shouldn't be
> considered as proposed patch.

yeah, I asked for it as an experiment not as a fix.
(Assignee)

Updated

6 years ago
Attachment #589478 - Flags: feedback?(trev.saunders)
(Assignee)

Comment 8

6 years ago
Created attachment 591712 [details] [diff] [review]
patch

noticed this while reviewing other stuff, it doesn't really make sense to treat "" as a valid atk plug id
Attachment #591712 - Flags: review?(surkov.alexander)

Comment 9

6 years ago
Comment on attachment 591712 [details] [diff] [review]
patch

r=me for accessible module change, since don't see anything bad here but when this case happens?
Attachment #591712 - Flags: review?(surkov.alexander) → review+
(Assignee)

Comment 10

6 years ago
(In reply to alexander :surkov from comment #9)
> Comment on attachment 591712 [details] [diff] [review]
> patch
> 
> r=me for accessible module change, since don't see anything bad here but
> when this case happens?

when the plugin  isn't accessible.  I'm not sure why  the plug id is "" but if I load a youtube video with a breakpoint in the constructor for AtkSocketAccessible I see that plugId its arg has mData of "".
(Assignee)

Comment 11

6 years ago
landed https://hg.mozilla.org/integration/mozilla-inbound/rev/e4e85a8b32c7
https://hg.mozilla.org/mozilla-central/rev/e4e85a8b32c7
Assignee: nobody → trev.saunders
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Comment on attachment 591712 [details] [diff] [review]
patch

Nice.
You need to log in before you can comment on or make changes to this bug.