Closed Bug 719022 Opened 9 years ago Closed 8 years ago

Digits-only file names get .css prefixed in front of postfixed

Categories

(DevTools :: Style Editor, defect, P2)

11 Branch
x86
Linux
defect

Tracking

(firefox11 verified)

VERIFIED FIXED
Firefox 12
Tracking Status
firefox11 --- verified

People

(Reporter: AlexLakatos, Assigned: paul)

References

Details

(Whiteboard: [qa!] [testday-20120203])

Attachments

(1 file, 2 obsolete files)

Digits-only file names get .css prefixed in front of postfixed

Steps to Reproduce
1.open the style editor
2.create a new style sheet
3.save it with a name with only digits, for example 1234.css

Actual results:
4.The stylesheet list shows css.1234

Expected results:
4.The stylesheet list shows 1234.css
The problem is that we use `direction:rtl;` to simulate `XUL:crop=start` (part the Style Editor is in HTML).

To get rid of this workaround, I need to use a <xul:label>.
Priority: -- → P2
Attached patch patch v1 (obsolete) — Splinter Review
Attached patch patch v1.1Splinter Review
Attachment #590794 - Attachment is obsolete: true
Attachment #590800 - Flags: review?(jwalker)
Attachment #590800 - Flags: feedback?(cedricv)
(we will need a followup bug for the '*' not being display)
Comment on attachment 590800 [details] [diff] [review]
patch v1.1

Review of attachment 590800 [details] [diff] [review]:
-----------------------------------------------------------------

Does that mean we've lost the dirty * when a file is edited?
Attachment #590800 - Flags: review?(jwalker) → review+
(In reply to Paul Rouget [:paul] from comment #4)
> (we will need a followup bug for the '*' not being display)

Ahh - missed this comment.
Blocks: 720468
Attachment #590800 - Flags: feedback?(cedricv) → feedback+
Whiteboard: [land-in-fx-team]
Assignee: nobody → paul
https://hg.mozilla.org/integration/fx-team/rev/2d2a7c5534e3
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
I will a? this patch once in central.
Whiteboard: [fixed-in-fx-team] → [fixed-in-fx-team][addToFirefox11]
Duplicate of this bug: 710811
https://hg.mozilla.org/mozilla-central/rev/2d2a7c5534e3
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team][addToFirefox11] → [addToFirefox11]
Target Milestone: --- → Firefox 12
Let's wait before a+ this.
The fix makes keyboard navigation in the list invisible.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 591531 [details] [diff] [review]
fix invisible outline for list keyboard navigation

Next time, please open a new bug.
Attachment #591531 - Flags: review?(paul) → review+
Well, it's a little tricky. Can you mark this bug as fixed and open a new bug?
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Attachment #591531 - Attachment is obsolete: true
Comment on attachment 590800 [details] [diff] [review]
patch v1.1

[Approval Request Comment]
Regression caused by (bug #): New Feature. Not a regression.
User impact if declined: Some stylesheet will be spelled wrong.
Testing completed (on m-c, etc.): on m-c, local testing.
Risk to taking this patch (and alternatives if risky): low. Styling changes and one XUL tag added.
Attachment #590800 - Flags: approval-mozilla-aurora?
Comment on attachment 590800 [details] [diff] [review]
patch v1.1

[Triage Comment]
Low risk fix in support of a new feature. Approved for Aurora.
Attachment #590800 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Whiteboard: [qa+]
Mozilla/5.0 (X11; Linux x86_64; rv:12.0a2) Gecko/20120202 Firefox/12.0a2
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20100101 Firefox/11.0

Verified using the steps from comment 0 on Ubuntu 11.10, Firefox 11 Beta 1 and Firefox Aurora (12). The file name is saved normally as "1234.css"
Status: RESOLVED → VERIFIED
Whiteboard: [qa+] → [qa!]
Whiteboard: [qa!] → [qa!] [testday-20120203]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.