719025 - Unity Plugin flickers in Firefox 10 beta

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Benoit Girard (:BenWa)]

From Bug 692759 Comment 144:
We are seeing the same bug in unity. Try installing the unity plugin, and going to http://unity3d.com/gallery/demos/live-demos to see the problem. In Firefox 10, when running in 64 bit mode, this shows very bad flicker.

Comment 1

[Benoit Girard (:BenWa)]

This is fixed in Aurora (11) and Nightly (12).

Turning off 'plugins.use_layers' fixes the problem. I think it's safer to disable the feature in Firefox 10 and wait for 11 rather then to try to uplift the requires patches in Firefox 10.

Comment 2

[Benoit Girard (:BenWa)]

Attachment: patch

Comment 3

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 589950 [details] [diff] [review]
patch

So this patch is intended only for the current beta branch?

On that assumption, this sounds reasonable to me.

Comment 4

[Benoit Girard (:BenWa)]

Comment on attachment 589950 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): 589950
User impact if declined: Flicker and regression with some plug-ins, including Unity.
Testing completed (on m-c, etc.): Checked that the feature is correctly 
Risk to taking this patch (and alternatives if risky): Low, flipping a switch to turn off a feature. Alternative is uplifting non trivial c++ code changes.

That's correct, turning this off once more :(. I wish these issues would turn up sooner.

Comment 5

[Alex Keybl [:akeybl]]

(In reply to Benoit Girard (:BenWa) from comment #4)
> Comment on attachment 589950 [details] [diff] [review]
> patch
> 
> [Approval Request Comment]
> Regression caused by (bug #): 589950

Hi Benoit - this doesn't appear to be the correct regressing bug. I'm interested in finding out how long the feature being disabled has been in the product, what platforms are affected, etc.

Comment 6

[Benoit Girard (:BenWa)]

(In reply to Alex Keybl [:akeybl] from comment #5)
> (In reply to Benoit Girard (:BenWa) from comment #4)
> > Comment on attachment 589950 [details] [diff] [review]
> > patch
> > 
> > [Approval Request Comment]
> > Regression caused by (bug #): 589950
> 
> Hi Benoit - this doesn't appear to be the correct regressing bug. I'm
> interested in finding out how long the feature being disabled has been in
> the product, what platforms are affected, etc.

I meant to link to this bug. This feature has never been enable. It was going to be enabled for the first time this release.

Comment 7

[Alex Keybl [:akeybl]]

Comment on attachment 589950 [details] [diff] [review]
patch

[Triage Comment]
Since this is the first release that we were going to enable this feature for, I have no issue with disabling for one more release. Approved for beta.

Comment 8

[Alex Keybl [:akeybl]]

(please land by tomorrow 1/23 evening to make beta 6)

Comment 9

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/releases/mozilla-beta/rev/138e167dcd3d

Comment 10

[Benoit Girard (:BenWa)]

This landed and should be fixed, please let us know if you see this again.