Closed Bug 719028 Opened 8 years ago Closed 8 years ago

Style Editor does not highlight a few CSS2.0 and CSS3 properties

Categories

(DevTools :: General, defect, P3)

11 Branch
defect

Tracking

(firefox12 fixed)

RESOLVED FIXED
Firefox 12
Tracking Status
firefox12 --- fixed

People

(Reporter: AlexLakatos, Assigned: AlexLakatos)

Details

(Whiteboard: [sourceeditor][orion][qa+])

Attachments

(1 file, 1 obsolete file)

Style editor does not highlight these properties yet:

CSS 3:
flex-align
flex-flow
flex-line-pack
flex-order
flex-pack

CSS 2.0:
marker-offset

The properties list was taken from http://meiert.com/en/indices/css-properties/ . Every other property listed there is highlighted.
Component: Developer Tools: Style Editor → Developer Tools
QA Contact: developer.tools.style.editor → developer.tools
Whiteboard: [sourceeditor][orion]
OS: Linux → All
Priority: -- → P3
Hardware: x86 → All
Attached patch patch v1.0 (obsolete) — Splinter Review
Added the 6 properties to CSS_KEYWORDS
Assignee: nobody → alex.lakatos
Status: NEW → ASSIGNED
Attachment #590517 - Flags: review?(mihai.sucan)
Comment on attachment 590517 [details] [diff] [review]
patch v1.0

Review of attachment 590517 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for your contribution Alex! r+!

A couple of comments below...

::: browser/devtools/sourceeditor/orion/orion.js
@@ +9,5 @@
>   * Contributors: 
>   *		Felipe Heidrich (IBM Corporation) - initial API and implementation
>   *		Silenio Quarti (IBM Corporation) - initial API and implementation
>   *		Mihai Sucan (Mozilla Foundation) - fix for Bug#364214
> + *		Alex Lakatos (Mozilla Contributor) - fix for Bug#719028

s/Bug/Mozilla Bug/

This is a Mozilla bug number, not an Eclipse project bug number.

@@ +10492,5 @@
> +		 "drop-initial-value", "elevation", "empty-cells", "fit", "fit-position", "flex-align", "flex-flow", "flex-inline-pack", "flex-order",
> +		 "flex-pack", "float", "float-offset", "font", "font-family", "font-size", "font-size-adjust", "font-stretch", "font-style",
> +		 "font-variant", "font-weight", "grid-columns", "grid-rows", "hanging-punctuation", "height", "hyphenate-after",
> +		 "hyphenate-before", "hyphenate-character", "hyphenate-lines", "hyphenate-resource", "hyphens", "icon", "image-orientation",
> +		  "image-rendering", "image-resolution", "inline-box-align", "left", "letter-spacing", "line-height", "line-stacking",

Nit: this line has an additional space that you should remove.
Attachment #590517 - Flags: review?(mihai.sucan) → review+
(In reply to Mihai Sucan [:msucan] from comment #3)
> > + *		Alex Lakatos (Mozilla Contributor) - fix for Bug#719028
> 
> s/Bug/Mozilla Bug/
> 
> This is a Mozilla bug number, not an Eclipse project bug number.
Should I log an Eclipse bug as well?
(In reply to Alex Lakatos from comment #4)
> (In reply to Mihai Sucan [:msucan] from comment #3)
> > > + *		Alex Lakatos (Mozilla Contributor) - fix for Bug#719028
> > 
> > s/Bug/Mozilla Bug/
> > 
> > This is a Mozilla bug number, not an Eclipse project bug number.
> Should I log an Eclipse bug as well?

For the purpose of fixing this bug in our codebase, that's not needed. However, you are free to do so, if you want to make this contribution upstream.

I suggested you replace "fix for Bug#719028" with "fix for Mozilla Bug#719028". Thanks!
Attached patch patch v1.1Splinter Review
Addressed the nits
Attachment #590517 - Attachment is obsolete: true
Attachment #590728 - Flags: review?(mihai.sucan)
Comment on attachment 590728 [details] [diff] [review]
patch v1.1

Review of attachment 590728 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #590728 - Flags: review?(mihai.sucan) → review+
Whiteboard: [sourceeditor][orion] → [sourceeditor][orion][land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/db26afebdd51
Whiteboard: [sourceeditor][orion][land-in-fx-team] → [sourceeditor][orion][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/db26afebdd51
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [sourceeditor][orion][fixed-in-fx-team] → [sourceeditor][orion]
Target Milestone: --- → Firefox 12
Whiteboard: [sourceeditor][orion] → [sourceeditor][orion][qa+]
The property flex-line-pack is not highlighted. Instead flex-inline-pack it is even though does not appear in the properties list here http://meiert.com/en/indices/css-properties/.
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.