Support CTRL-SHIFT-K as the Lighting Task Quick Filter hotkey.

RESOLVED FIXED

Status

SeaMonkey
MailNews: General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Philip Chee, Assigned: Philip Chee)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
From Bug 316916 Comment 32:
>> So if SeaMonkey implements a dummy "cmd_showQuickFilterBar", the lightning
>> shortcut would work?

> Yes, Seamonkey needs a dummy command with that name and a keyboard shortcut
> that executes that command. The command needs to be exposed via the tabmail's
> command handler.
(Assignee)

Comment 1

5 years ago
Created attachment 589499 [details] [diff] [review]
Patch v1.0 Proposed Hot Key Fix.

> This patch works with both the cmd_showQuickFilterBar (Ctrl+Shift+K) and the
> cmd_find (Ctrl+F) commands in Thunderbird. Only the cmd_find command currently
> works in Seamonkey, so that shortcut is used for the placeholder text. If
> Seamonkey implements the QuickFilterBar commands in the future, we would only
> need to update the strings.
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
Attachment #589499 - Flags: review?(iann_bugzilla)

Comment 2

5 years ago
Comment on attachment 589499 [details] [diff] [review]
Patch v1.0 Proposed Hot Key Fix.

>   <key key="&focusSearchInput.key;"
>        modifiers="accel"
>        oncommand="focusElement(document.getElementById('searchInput'));"/>
> 
>+    <!-- Needed to support the Lightning Task filter See Bug 316916 -->
>+    <key id="key_qfb_show"
>+         key="&quickFilterBar.show.key2;"
>+         modifiers="accel,shift"
>+         command="cmd_showQuickFilterBar"/>
Nit: indented too far.
Attachment #589499 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 3

5 years ago
> Nit: indented too far.
Fixed locally.
(Assignee)

Comment 4

5 years ago
Comment on attachment 589499 [details] [diff] [review]
Patch v1.0 Proposed Hot Key Fix.

For some reason I forgot to ask for moa from Mnyromyr :P
Attachment #589499 - Flags: superreview?(mnyromyr)

Updated

5 years ago
Attachment #589499 - Flags: superreview?(mnyromyr) → superreview+
(Assignee)

Comment 5

5 years ago
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/ad14796cbb77
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.