719127 - Debugger error: jschar out of char range; high bits of data lost

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

STR:

1) Visit http://www.mozilla.org/en-US/firefox/dl
2) Open the Script Debugger.

Because of the em dash (or en dash) character in the page title, the following errors appear in the console (stdout):

DBG-SERVER: Got: {
  "from": "root",
  "applicationType": "browser",
  "traits": []
}
DBG-SERVER: Got: {
  "to": "root",
  "type": "listTabs"
}
WARNING: jschar out of char range; high bits of data lost: 0x2014: file /Users/past/src/remote-debug/js/xpconnect/src/XPCConvert.cpp, line 426
DBG-SERVER: Error parsing incoming packet: {
  "from": "root",
  "selected": 2,
  "tabs": [
    {
      "actor": "conn0.tab2",
      "title": "Debugger test page",
      "url": "http://htmlpad.org/debugger/"
    },
    {
      "actor": "conn0.tab3",
      "title": "Spellchecker",
      "url": "http://astithas.com/speller/"
    },
    {
      "actor": "conn0.tab4",
      "title": "Mozilla Firefox Web Browser  Free Download",
      "url": "http://www.mozilla.org/en-US/firefox/dl"
    }
  ]
} (SyntaxError: JSON.parse: bad control character in string literal - DT_processIncoming()@chrome://global/content/devtools/dbg-transport.js:162
DT_onDataAvailable([object XPCWrappedNative_NoHelper],null,[object XPCWrappedNative_NoHelper],71,456)@chrome://global/content/devtools/dbg-transport.js:128
)

Comment 1

[Rob Campbell [:rc] (:robcee)]

JSON.parse strikes again!

Comment 2

[Dave Camp (:dcamp)]

Attachment: properly encode before sending across the wire

Not json.parse, just bad use of streaming APIs.  I should know better.

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 596196 [details] [diff] [review]
properly encode before sending across the wire

Review of attachment 596196 [details] [diff] [review]:
-----------------------------------------------------------------

Works as advertised.

::: toolkit/devtools/debugger/tests/unit/test_dbgsocket.js
@@ +40,4 @@
>        transport.send({to: "root",
>                        type: "echo",
> +                      reallylong: really_long(),
> +                      unicode: "(╯°□°）╯︵ ┻━┻"});

Nit: moving the Unicode string to a variable would avoid some typing and ensure we test for the same thing.

Comment 5

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 596196 [details] [diff] [review]
properly encode before sending across the wire

f+ for using tableflip guy!

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/4ea8c90ff02a