Closed Bug 719130 Opened 10 years ago Closed 10 years ago

Open in new tab context menu option does not work if no SeaMonkey browser window already open

Categories

(Other Applications :: ChatZilla, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla12

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

Details

(Whiteboard: [cz-0.9.88.1])

Attachments

(1 file)

This is on 0.9.88 of chatzilla

Steps to reproduce:
1/ Open SeaMonkey and start chatzilla
2/ Close any open browser windows
3/ Right click on a link within chat window and select open in new tab

Expected result
1/ Link opens in new window

Actual result
1/ No window opens, no relevant message in error console
This patch:
* Tweaks behaviour so if there is no browser window available then take the same route as if opening a browser windows instead of a tab.
Assignee: rginda → iann_bugzilla
Status: NEW → ASSIGNED
Attachment #589736 - Flags: review?
Attachment #589736 - Flags: review? → review?(gijskruitbosch+bugs)
Comment on attachment 589736 [details] [diff] [review]
Fix opening of tabs [Checked in: Comment 3]

I also missed the case of goto-url with no browser window in this code. :(

r=silver as-is or with the same or-condition for goto-url added.
Attachment #589736 - Flags: review?(gijskruitbosch+bugs) → review+
Comment on attachment 589736 [details] [diff] [review]
Fix opening of tabs [Checked in: Comment 3]

http://hg.mozilla.org/chatzilla/rev/ff653bc00394
Added additional check for "goto-url" and no browser window.
Attachment #589736 - Attachment description: Fix opening of tabs → Fix opening of tabs [Checked in: Comment 3]
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Whiteboard: [cz-0.9.88.1]
You need to log in before you can comment on or make changes to this bug.