719130 - Open in new tab context menu option does not work if no SeaMonkey browser window already open

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Ian Neal]

This is on 0.9.88 of chatzilla

Steps to reproduce:
1/ Open SeaMonkey and start chatzilla
2/ Close any open browser windows
3/ Right click on a link within chat window and select open in new tab

Expected result
1/ Link opens in new window

Actual result
1/ No window opens, no relevant message in error console

Comment 1

[Ian Neal]

Attachment: Fix opening of tabs [Checked in: Comment 3]

This patch:
* Tweaks behaviour so if there is no browser window available then take the same route as if opening a browser windows instead of a tab.

Comment 2

[James Ross]

Comment on attachment 589736 [details] [diff] [review]
Fix opening of tabs [Checked in: Comment 3]

I also missed the case of goto-url with no browser window in this code. :(

r=silver as-is or with the same or-condition for goto-url added.

Comment 3

[Ian Neal]

Comment on attachment 589736 [details] [diff] [review]
Fix opening of tabs [Checked in: Comment 3]

http://hg.mozilla.org/chatzilla/rev/ff653bc00394
Added additional check for "goto-url" and no browser window.