The default bug view has changed. See this FAQ.

Remove support for nested event loop filters

RESOLVED FIXED in mozilla14

Status

()

Core
XPCOM
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: bsmedberg, Assigned: bsmedberg)

Tracking

unspecified
mozilla14
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 589582 [details] [diff] [review]
Remove nested event loop filtering, rev. 1

With the removal of XPCOM proxies, we can now safely also remove the rather complicated thread support for nested event loop filters. These never worked well because native events weren't usefully filtered, and even if we want to end up with something like DOM event sources as in the HTML spec, the current code will not be useful at all.
Attachment #589582 - Flags: review?(dbaron)
Could you ask somebody else to review this?
(Assignee)

Comment 2

5 years ago
Comment on attachment 589582 [details] [diff] [review]
Remove nested event loop filtering, rev. 1

Apparently I need to find somebody to own/be a peer of this code.
Attachment #589582 - Flags: review?(dbaron) → review?(justin.lebar+bug)
Comment on attachment 589582 [details] [diff] [review]
Remove nested event loop filtering, rev. 1

This patch is clearly fine in itself, but I admit that I don't know what an xpcom proxy is or why their removal means we can remove this code.  I'm reading bug 675221, but I may be at it for a while.  :)
Attachment #589582 - Flags: review?(justin.lebar+bug) → review+
Okay, I see.  Or at least, think I've seen enough!  :)
https://hg.mozilla.org/mozilla-central/rev/1b05e9751f34
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
Duplicate of this bug: 582120
You need to log in before you can comment on or make changes to this bug.