Closed Bug 719191 Opened 10 years ago Closed 7 years ago

Software Update test to check for About dialog

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: u279076, Unassigned)

References

()

Details

(Whiteboard: [mozmill-update])

Attachments

(1 file)

We need a Mozmill test to for the Default Compatible Add-ons automation. To begin with, we need to develop a test which checks the About dialog without restarting, instantiating the software-update class.

Step 1 will be making a test which covers the following Litmus test:
https://litmus.mozilla.org/show_test.cgi?id=15416

Here is the SoftwareUpdate class for reference:
hg.mozilla.org/qa/mozmill-tests/file/default/lib/software-update.js
Alex, I'm assigning this to you. Please make it your top priority. I want to see a first patch up for review by tomorrow evening (your time). Henrik and I will both be the reviewers for this work.

Henrik, please add any requirements/feedback to this bug so Alex can get this implemented in as little time possible.

Thanks
Assignee: nobody → alex.lakatos
We should instantiate the softwareUpdate class once so we get the list of installed add-ons.
Attached patch patch v0.1Splinter Review
Open the About Dialog and check that the "Check for updates" button is enabled
Attachment #589881 - Flags: review?(hskupin)
Attachment #589881 - Flags: review?(anthony.s.hughes)
Comment on attachment 589881 [details] [diff] [review]
patch v0.1

This looks fine to me as a baseline/reference test. I'll pass it over to Henrik for review.

Henrik, are there any other requirements for this test which I am unaware? In my opinion this covers the Litmus test and the usage of softwareUpdate class that you wanted.
Attachment #589881 - Flags: review?(anthony.s.hughes) → review+
To fully cover the test we have to ensure that clicking the button actually performs an update check. Whether it will find an update or not. Both cases should be handled. Otherwise it looks fine for now.
Just found that we already have a method in the software-update module which opens the about window and performs a simple check:

http://hg.mozilla.org/qa/mozmill-tests/file/mozilla-release/lib/software-update.js#l353
Attachment #589881 - Flags: review?(hskupin)
(In reply to Henrik Skupin (:whimboo) from comment #6)
> Just found that we already have a method in the software-update module which
> opens the about window and performs a simple check:
> 
> http://hg.mozilla.org/qa/mozmill-tests/file/mozilla-release/lib/software-
> update.js#l353
That's where I took the code. I did not use it because I thought our assert modules would give a more readable error message.
In such a case you should update the shared module instead.
Status: NEW → ASSIGNED
Assignee: alex.lakatos → nobody
Status: ASSIGNED → NEW
Priority: -- → P2
Depends on: 599290
Anthony, the originally referenced Litmus test is no longer available. Do you think such a test is still valid? If yes, can you give more details in what needs to be done? Thanks.
Flags: needinfo?(anthony.s.hughes)
This was so long ago that I can't recall. It's quite possible that the test itself is invalid but I cannot confirm since we've lost reference to the Litmus test. If we've survived this long without it, perhaps it's not a high priority. Feel free to close this bug.
Flags: needinfo?(anthony.s.hughes)
Our update tests also go through this dialog for a long time now. So I agree in getting this bug closed.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.