719240 - Don't dispatch touchmove events if the user's finger hasn't moved far

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

Attachment: Patch

Follow up to Bug 603008. Google Maps expects that we don't dispatch touchmove events if the users finger hasn't moved much, and uses this to detect taps (and double taps). This brings us in line with their expectations.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 589652 [details] [diff] [review]
Patch

>+        if (initialTouchLocation != null && (action & MotionEvent.ACTION_MASK) == MotionEvent.ACTION_MOVE) {
>+            if (PointUtils.subtract(point, initialTouchLocation).length() > PanZoomController.PAN_THRESHOLD * 240) {
>+                initialTouchLocation = null;
>+            } else {
>+                return !allowDefaultActions;
>+            }
>+        }

Is this location for setting initialTouchLocation = null good enough? I worry that something could happen and we are stuck in a non-null situation. It looks like it should be good enough, I just wanted you to think about it a bit more.

Comment 2

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1b16c4bd7aa2

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/1b16c4bd7aa2

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Wes, please request aurora approval

Comment 5

[Wesley Johnston (:wesj)]

Comment on attachment 589652 [details] [diff] [review]
Patch

User impact if declined: No multitouch
Testing completed (on m-c, etc.): On mc since 1/24
Risk to taking this patch (and alternatives if risky): Low risk. Mobile only. Currently disabled

Comment 6

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/releases/mozilla-beta/rev/105917581955