Fennec cannot init EGL libs due to wrong library name

RESOLVED FIXED in Firefox 11

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
mozilla12
x86
Linux
Points:
---

Firefox Tracking Flags

(firefox11 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
In bug 716825

not only full path to libraries was removed, but also library names changed too
for example:
-#define EGL_LIB "/usr/lib/libEGL.so"
-#define GLES2_LIB "/usr/lib/libGLESv2.so"
+#define EGL_LIB "libEGL.so.1"
+#define GLES2_LIB "libGLESv2.so.2"

Not sure home many non-android egl based systems we have, but most of them similar to android have only libEGL.so, and without api suffix.
(Assignee)

Comment 1

6 years ago
Created attachment 589692 [details] [diff] [review]
Switch back to old library names
Attachment #589692 - Flags: review?(mh+mozilla)
Comment on attachment 589692 [details] [diff] [review]
Switch back to old library names

Review of attachment 589692 [details] [diff] [review]:
-----------------------------------------------------------------

See bug 716825 comment 7
Attachment #589692 - Flags: review?(mh+mozilla) → review-
(Assignee)

Comment 3

6 years ago
Created attachment 590125 [details] [diff] [review]
Lookup for EGL library
Assignee: nobody → romaxa
Attachment #589692 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #590125 - Flags: review?(mh+mozilla)
Comment on attachment 590125 [details] [diff] [review]
Lookup for EGL library

Review of attachment 590125 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContextProviderEGL.cpp
@@ +385,5 @@
>  #endif
>  
>          if (!mEGLLibrary) {
>              mEGLLibrary = PR_LoadLibrary(EGL_LIB);
> +#if defined(XP_UNIX)

It's probably too broad, but it doesn't hurt.
Attachment #590125 - Flags: review?(mh+mozilla) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed

Comment 5

6 years ago
https://hg.mozilla.org/mozilla-central/rev/cf45def338fa
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Comment on attachment 590125 [details] [diff] [review]
Lookup for EGL library

[Approval Request Comment]
Regression caused by bug 716825, which is a dependency of bug 683127.
Attachment #590125 - Flags: approval-mozilla-aurora?
Attachment #590125 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/47cb704586dc
status-firefox11: --- → fixed
You need to log in before you can comment on or make changes to this bug.