Closed Bug 719253 Opened 12 years ago Closed 12 years ago

Fennec cannot init EGL libs due to wrong library name

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla12
Tracking Flags:
Tracking Status
firefox11 --- fixed

People

(Reporter: romaxa, Assigned: romaxa)

References

Details

Attachments

(1 file, 1 obsolete file)

Lookup for EGL library
1.58 KB, patch
glandium
: review+
blassey
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
In bug 716825

not only full path to libraries was removed, but also library names changed too
for example:
-#define EGL_LIB "/usr/lib/libEGL.so"
-#define GLES2_LIB "/usr/lib/libGLESv2.so"
+#define EGL_LIB "libEGL.so.1"
+#define GLES2_LIB "libGLESv2.so.2"

Not sure home many non-android egl based systems we have, but most of them similar to android have only libEGL.so, and without api suffix.
Attached patch Switch back to old library names (obsolete) — — Splinter Review 

        Attachment #589692 -
        Flags: review?(mh+mozilla)

    
    

    
  
Comment on attachment 589692 [details] [diff] [review]
Switch back to old library names

Review of attachment 589692 [details] [diff] [review]:
-----------------------------------------------------------------

See bug 716825 comment 7

        Attachment #589692 -
        Flags: review?(mh+mozilla) → review-

    
    

    
  


  
Assignee: nobody → romaxa

        Attachment #589692 -
        Attachment is obsolete: true
Status: NEW → ASSIGNED

        Attachment #590125 -
        Flags: review?(mh+mozilla)

    
    

    
  
Comment on attachment 590125 [details] [diff] [review]
Lookup for EGL library

Review of attachment 590125 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContextProviderEGL.cpp
@@ +385,5 @@
>  #endif
>  
>          if (!mEGLLibrary) {
>              mEGLLibrary = PR_LoadLibrary(EGL_LIB);
> +#if defined(XP_UNIX)

It's probably too broad, but it doesn't hurt.

        Attachment #590125 -
        Flags: review?(mh+mozilla) → review+

    
  
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/cf45def338fa
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla12

    
    

    
  
Comment on attachment 590125 [details] [diff] [review]
Lookup for EGL library

[Approval Request Comment]
Regression caused by bug 716825, which is a dependency of bug 683127.

        Attachment #590125 -
        Flags: approval-mozilla-aurora?

        Attachment #590125 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

          You need to log in
          before you can comment on or make changes to this bug.