719263 - sign_android script should verify passwords before signing

Status: RESOLVED DUPLICATE of bug 705214

(Release Engineering :: General, defect, P3)

Description

[Chris Cooper [:coop] (he/him)]

I ran into an issue with signing for 10.0b5:

https://wiki.mozilla.org/Releases/Firefox_10.0b5/BuildNotes#Android_Signature_Verification

In short, I had the wrong store password, but the script didn't halt. It continued to the point of uploading the improperly signed apks. This triggered the verification step which subsequently failed.

We should be able to leverage some smarts from the CombinedSigning process here namely:

* accepting both passwords up-front so you only have to input them once
* verifying the passwords with a test signing before using them on the actual apks
* allow for password re-entry if an error is detected, or at the very least, halt the script so we don't upload unsigned apks as signed

Comment 1

[Aki Sasaki (not active)]

The new mozharness script should fix this.
It's due along with the rest of my work by 1/31, so in the near future.