Site-specific zoom level shouldn't apply to video and plugin documents

RESOLVED FIXED in Firefox 12

Status

()

Firefox
General
--
minor
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Tracking

({polish})

Trunk
Firefox 12
polish
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Bug 416661 excluded images from site-specific zooming, because "it is quite annoying to see normal pages zoomed when using pagezoom to zoom images" (bug 416661 comment 0).

Bug 575830 comment 33 pointed out that this the same logic applies to other media document types, like video documents.  We should update the code in browser-fullZoom.js to check mozSyntheticDocument instead of just "instanceof ImageDocument".

Comment 1

6 years ago
Try run for 8b7a0a182a1d is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=8b7a0a182a1d
Results (out of 8 total builds):
    exception: 8
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/mbrubeck@mozilla.com-8b7a0a182a1d
(Assignee)

Comment 2

6 years ago
Created attachment 590090 [details] [diff] [review]
patch
Attachment #590090 - Flags: review?
(Assignee)

Updated

6 years ago
Attachment #590090 - Flags: review? → review?(gavin.sharp)

Comment 3

6 years ago
Try run for 0b586a5b7229 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=0b586a5b7229
Results (out of 155 total builds):
    success: 136
    warnings: 18
    failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/mbrubeck@mozilla.com-0b586a5b7229
Comment on attachment 590090 [details] [diff] [review]
patch

Did the test fail before the patch? Jared suggested it doesn't in bug 575830 comment 35. Maybe some other form of synthetic document would make a better test?
Attachment #590090 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 5

6 years ago
(In reply to Gavin Sharp (use gavin@gavinsharp.com for email) from comment #4)
> Did the test fail before the patch? Jared suggested it doesn't in bug 575830
> comment 35. Maybe some other form of synthetic document would make a better
> test?

Yes, the test fails without the patch.  Before the patch, video documents used site-specific zoom.  So they weren't affected by bug 575830 (zoom resets to 1 on tab switching), but zooming a video would cause other pages in the site to zoom and vice-versa (which is the problem that bug 416661 fixed for images).
(Assignee)

Comment 6

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ade1cb934f01
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox 12

Comment 7

6 years ago
https://hg.mozilla.org/mozilla-central/rev/ade1cb934f01
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

5 years ago
Duplicate of this bug: 466909
Depends on: 806046
Depends on: 842001
You need to log in before you can comment on or make changes to this bug.